Turn deprecation lint legacy_imports into a hard error - #50760
Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
Contributor
|
Seems reasonable. =) Do we feel the need to do a final "cargo check" crater run? (So we can cc the relevant people) |
Contributor
|
OTOH if previous runs found no regressions, and we are deny by default, seems like overkill. |
nikomatsakis
approved these changes
May 15, 2018
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit d1b0274 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit d1b0274 with merge 413bc952821db174ec08d4338f7fbbc2ec468124... |
Collaborator
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Member
|
@bors retry 1 second is not enough for the OS to close the port? |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
May 19, 2018
Turn deprecation lint `legacy_imports` into a hard error Closes #38260 The lint was introduced in Dec 2016, then made deny-by-default in Jun 2017 when crater run found 0 regressions caused by it. This lint requires some not entirely trivial amount of import resolution logic that (surprisingly or not) interacts with `feature(use_extern_macros)` (#35896), so it would be desirable to remove it before stabilizing `use_extern_macros`. In particular, this PR fixes the failing example in #50725 (but not the whole issue, `use std::panic::{self}` still can cause other undesirable errors when `use_extern_macros` is enabled).
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38260
The lint was introduced in Dec 2016, then made deny-by-default in Jun 2017 when crater run found 0 regressions caused by it.
This lint requires some not entirely trivial amount of import resolution logic that (surprisingly or not) interacts with
feature(use_extern_macros)(#35896), so it would be desirable to remove it before stabilizinguse_extern_macros.In particular, this PR fixes the failing example in #50725 (but not the whole issue,
use std::panic::{self}still can cause other undesirable errors whenuse_extern_macrosis enabled).