Skip to content

SIMD for Rust, take 2 - #6214

Merged
bors merged 7 commits into
rust-lang:incomingfrom
sanxiyn:simd-2
May 8, 2013
Merged

SIMD for Rust, take 2#6214
bors merged 7 commits into
rust-lang:incomingfrom
sanxiyn:simd-2

Conversation

@sanxiyn

@sanxiyn sanxiyn commented May 3, 2013

Copy link
Copy Markdown
Contributor

At the moment this only includes type checking and there is no code generation support yet. I wanted to get the design reviewed first.

From discussion with @graydon at #5841, re-implemented as #[simd] attribute on structs.

Progressing towards #3499.

@sanxiyn

sanxiyn commented May 3, 2013

Copy link
Copy Markdown
Contributor Author

One issue I found is that it is no longer possible to decide whether type is a SIMD vector solely from type. You also need type context. This means, for example, pub fn type_is_immediate(ty: t) -> bool signature needs to change.

Or do you have a better idea?

@graydon

graydon commented May 7, 2013

Copy link
Copy Markdown
Contributor

This looks pretty good to me. Thanks for the patient revisions.

Since I am less aware of what servo will need / want in this area (and haven't written SIMD code in years) perhaps @pcwalton should also take a look to confirm?

@sanxiyn

sanxiyn commented May 7, 2013

Copy link
Copy Markdown
Contributor Author

Rebased.

@brson

brson commented May 8, 2013

Copy link
Copy Markdown
Contributor

Can we put the library parts in core::unstable? This is an experimental feature.

@yichoi

yichoi commented May 8, 2013

Copy link
Copy Markdown
Contributor

sounds reasonable to locate core::unstable

@sanxiyn

sanxiyn commented May 8, 2013

Copy link
Copy Markdown
Contributor Author

Moved.

@nikomatsakis

Copy link
Copy Markdown
Contributor

@sanxiyn I read over the patch. It looks pretty good to me so far.

bors added a commit that referenced this pull request May 8, 2013
At the moment this only includes type checking and there is no code generation support yet. I wanted to get the design reviewed first.

From discussion with @graydon at #5841, re-implemented as `#[simd]` attribute on structs.

Progressing towards #3499.
@bors bors closed this May 8, 2013
@bors
bors merged commit eb5fa06 into rust-lang:incoming May 8, 2013
@bstrie bstrie mentioned this pull request Jun 25, 2013
bors added a commit that referenced this pull request Jul 12, 2013
Fix #3499.

This is the other half of #5841 that was left out when I revised it to #6214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants