Skip to content

Track -C link-dead-code during incremental compilation - #84226

Merged
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:track-link-dead-code
Apr 16, 2021
Merged

Track -C link-dead-code during incremental compilation#84226
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:track-link-dead-code

Conversation

@Aaron1011

Copy link
Copy Markdown
Contributor

This option influences monomorphization, which participates in
incremental compilation.

This option influences monomorphization, which participates in
incremental compilation.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2021
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 15, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 1ce1cda has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2021
@Mark-Simulacrum

Copy link
Copy Markdown
Member

I wonder if we should wrap the untracked values in some kind of Untracked<T>(T) newtype and force users to call read_untracked() or something like that. Maybe too noisy.

@bors

bors commented Apr 16, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1ce1cda with merge e87c4dd...

@bors

bors commented Apr 16, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing e87c4dd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2021
@bors
bors merged commit e87c4dd into rust-lang:master Apr 16, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants