Skip to content

Grant try permissions to Rust for Linux marker team - #1512

Merged
jackh726 merged 1 commit into
rust-lang:masterfrom
ojeda:ojeda-bors-rust-try
Aug 2, 2024
Merged

Grant try permissions to Rust for Linux marker team#1512
jackh726 merged 1 commit into
rust-lang:masterfrom
ojeda:ojeda-bors-rust-try

Conversation

@ojeda

@ojeda ojeda commented Jul 28, 2024

Copy link
Copy Markdown
Contributor

In order to test changes to the RFL CI job, if needed.

Cc: @Kobzol

@Kobzol

Kobzol commented Jul 28, 2024

Copy link
Copy Markdown
Member

Maybe we should add the permissions to the whole RfL group? Not sure what's the policy on try permissions for individual users (I'll let others chime in).

@ojeda

ojeda commented Jul 28, 2024

Copy link
Copy Markdown
Contributor Author

If you are comfortable adding all of them, of course! All but 2 of them, I think, are already Rust contributors.

@joshtriplett

Copy link
Copy Markdown
Member

👍 for granting try permissions to the entire RfL team within the teams repo.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@ojeda
ojeda force-pushed the ojeda-bors-rust-try branch from ee81071 to 9a92345 Compare August 1, 2024 13:20
@ojeda

ojeda commented Aug 1, 2024

Copy link
Copy Markdown
Contributor Author

Thanks Josh!

Updated PR.

@joshtriplett

Copy link
Copy Markdown
Member

@ojeda You should update the PR title too.

@ojeda ojeda changed the title Grant try permissions to myself Grant try permissions to Rust for Linux marker team Aug 2, 2024

@jackh726 jackh726 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with @tmandry's approval here as lang-team lead here - but I think in general this makes a lot of sense.

@jackh726
jackh726 merged commit d1fd70b into rust-lang:master Aug 2, 2024
@ojeda
ojeda deleted the ojeda-bors-rust-try branch August 2, 2024 16:31
@ojeda

ojeda commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

Thanks Jack!

tmandry added a commit to tmandry/team that referenced this pull request Nov 8, 2024
This is so they can update the Fuchsia pin (e.g. rust-lang/rust#132294, which is only practical because of my status as compiler team member). For the same reason this was done for the Rust for Linux team in rust-lang#1512.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants