Skip to content

feat: allow the rendering of relative paths - #13812

Closed
steamer2k wants to merge 2 commits into
sveltejs:mainfrom
steamer2k:2025-05-21_relativePath
Closed

feat: allow the rendering of relative paths#13812
steamer2k wants to merge 2 commits into
sveltejs:mainfrom
steamer2k:2025-05-21_relativePath

Conversation

@steamer2k

@steamer2k steamer2k commented May 22, 2025

Copy link
Copy Markdown

resolves #595
resolves #9569

Allows building SPA sites with a relative asset path.

E.g., whether server from:

  • https://some.server/foo
  • https://some.server/foo/bar
  • https://some.server/foo/bar/baz

...the SPA should be able to find the _app/ subdirectory as a sibling to the fallback page. E.g., given a fallback page of index.html:

someDirectory/
  index.html
  _app/
    immutable/
      assets/...
      chunks/...
      entry/...
      nodes/...
    env.js
    version.json

When kit.paths.relative is set, this change renders references to the _app/ directory with a leading . so the browser interprets them as relative paths.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented May 22, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9b9e364

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steamer2k

Copy link
Copy Markdown
Author

I'll see about following up on tests, lints and changesets tomorrow.

@Pandoks

Pandoks commented May 22, 2025

Copy link
Copy Markdown

This also allows you to serve the web app through file:// for things like embedded systems, tvs, first class electron support, etc.

Any app where you have direct access to the files and serve start from the index.html without needing to inline your entire app if it's huge.

Pandoks added a commit to Pandoks/sveltronkit that referenced this pull request May 22, 2025
@teemingc teemingc changed the title Tries to allow the rendering of relative paths feat: allow the rendering of relative paths May 30, 2025
@jlamoreaux

Copy link
Copy Markdown

Just curious if this PR is abandoned or still actively being worked on? Definitely interested in the ability to use relative paths on SPAs

@steamer2k

Copy link
Copy Markdown
Author

Just curious if this PR is abandoned or still actively being worked on? Definitely interested in the ability to use relative paths on SPAs

Sorry. I'm not actively working on it. It'd be great if someone wanted to work through the test cases. Otherwise, maybe I'll get back to it eventually.

@Rich-Harris

Copy link
Copy Markdown
Member

thank you but this isn't right #9569 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for relative paths of assets when building for static deployments Dynamic basepath

4 participants