readme: remove reference to backend/application.py - #4048
Merged
Conversation
Summary: Before `--samples_per_plugin` existed, the only way to change the sampling thresholds was to patch `application.py` manually. But the flag has been the right way to do this since #1138, and manual patching has been insufficient since the flag value was exposed to plugins in #3271. There’s no need to discuss this implementation detail any more. wchargin-branch: readme-remove-application-reference wchargin-source: b79027ec8b279537bdf38f7b5d7f36cf5dd38498
bileschi
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Before
--samples_per_pluginexisted, the only way to change thesampling thresholds was to patch
application.pymanually. But the flaghas been the right way to do this since #1138, and manual patching has
been insufficient since the flag value was exposed to plugins in #3271.
There’s no need to discuss this implementation detail any more.
wchargin-branch: readme-remove-application-reference