Skip to content

Update lockfile spec - #246

Merged
thelovekesh merged 2 commits into
mainfrom
update/resolver
Jun 9, 2026
Merged

Update lockfile spec#246
thelovekesh merged 2 commits into
mainfrom
update/resolver

Conversation

@thelovekesh

Copy link
Copy Markdown
Collaborator
  • Remove resolved url from lockfile and move to build it dynamically using name + version.
  • Add signatures to the lockfile, and remove extra remote call to fetch signatures.

@thelovekesh thelovekesh added the core changes made in cli core api label Jun 9, 2026
@thelovekesh
thelovekesh requested a review from Copilot June 9, 2026 17:15
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

📦 wpm cli builds 📦

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dependency lockfile format and installation flow to stop storing tarball “resolved” URLs, instead deriving tarball paths from name@version, and to persist package signatures in the lockfile so installs can verify signatures without an extra manifest fetch.

Changes:

  • Update wpm.lock package entries: remove resolved, add signatures.
  • Propagate signatures through resolution and install planning so the installer can verify without fetching manifests.
  • Derive tarball download paths dynamically from package name + version.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/pm/wpmlock/lockfile.go Updates lockfile package schema to include signatures and drop resolved URLs.
pkg/pm/resolution/resolver.go Propagates signatures from manifests/lockfile into resolved nodes.
pkg/pm/installer/plan.go Carries signatures into install/update actions.
pkg/pm/installer/installer.go Removes manifest fetch for signatures; derives tarball path from name/version.
cli/command/install/run.go Writes signatures into the lockfile when updating packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/pm/wpmlock/lockfile.go
Comment thread pkg/pm/resolution/resolver.go
@thelovekesh
thelovekesh merged commit 144f2e8 into main Jun 9, 2026
18 checks passed
@thelovekesh
thelovekesh deleted the update/resolver branch June 9, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core changes made in cli core api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants