Update lockfile spec - #246
Merged
Merged
Conversation
thelovekesh
commented
Jun 9, 2026
Collaborator
- Remove resolved url from lockfile and move to build it dynamically using name + version.
- Add signatures to the lockfile, and remove extra remote call to fetch signatures.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dependency lockfile format and installation flow to stop storing tarball “resolved” URLs, instead deriving tarball paths from name@version, and to persist package signatures in the lockfile so installs can verify signatures without an extra manifest fetch.
Changes:
- Update
wpm.lockpackage entries: removeresolved, addsignatures. - Propagate signatures through resolution and install planning so the installer can verify without fetching manifests.
- Derive tarball download paths dynamically from package name + version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/pm/wpmlock/lockfile.go | Updates lockfile package schema to include signatures and drop resolved URLs. |
| pkg/pm/resolution/resolver.go | Propagates signatures from manifests/lockfile into resolved nodes. |
| pkg/pm/installer/plan.go | Carries signatures into install/update actions. |
| pkg/pm/installer/installer.go | Removes manifest fetch for signatures; derives tarball path from name/version. |
| cli/command/install/run.go | Writes signatures into the lockfile when updating packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.