Add Flutter 2.0.1 CLI Autocompletion - #40
Merged
rolandtshen merged 11 commits intoMar 25, 2021
Merged
Conversation
added 7 commits
March 11, 2021 16:21
rolandtshen
reviewed
Mar 19, 2021
Comment on lines
+1243
to
+1246
| help, | ||
| verbose, | ||
| deviceUser, | ||
| deviceTimeout, |
Contributor
There was a problem hiding this comment.
looks like the docs say there's a -d option that takes a device id as an argument
Author
There was a problem hiding this comment.
Oh yeah, I missed that, I should better use globalOpts instead because I saw globalOpts could be used everywhere
rolandtshen
reviewed
Mar 19, 2021
Comment on lines
+749
to
+779
| name: "aar", | ||
| description: "Build a repository containing an AAR and a POM file." | ||
| }, | ||
| { | ||
| name: "apk", | ||
| description: "Build an Android APK file from your app.", | ||
| }, | ||
| { | ||
| name: "appbundle", | ||
| description: "Build an Android App Bundle file from your app." | ||
| }, | ||
| { | ||
| name: "bundle", | ||
| description: "Build the Flutter assets directory from your app." | ||
| }, | ||
| { | ||
| name: "ios", | ||
| description: "Build an iOS application bundle (Mac OS X host only)." | ||
| }, | ||
| { | ||
| name: "ios-framework", | ||
| description: "Produces .xcframeworks for a Flutter project and its plugins for integration into existing, plain Xcode projects." | ||
| }, | ||
| { | ||
| name: "ipa", | ||
| description: "Build an iOS archive bundle (Mac OS X host only)." | ||
| }, | ||
| { | ||
| name: "web", | ||
| description: "Build a web application bundle." | ||
| }, |
Contributor
There was a problem hiding this comment.
These seem to be suggestions that would go under a suggestions array in the args object, instead of options
Author
There was a problem hiding this comment.
Ah sure, I replaced this to suggestions instead of options in the latest commit
rolandtshen
suggested changes
Mar 19, 2021
| { | ||
| name: ["-t", "--template"], | ||
| insertValue: "--template {cursor}", | ||
| description: "Specify the type of project to create. [app] (default) Generate a Flutter application. [module] Generate a project to add a Flutter module to an existing Android or iOS application. [package] Generate a shareable Flutter project containing modular Dart code. [plugin] Generate a shareable Flutter project containing an API in Dart code with a platform-specific implementation for Android, for iOS code, or for both.", |
| { | ||
| name: ["-r", "--reporter"], | ||
| insertValue: "--reporter", | ||
| description: "Set how to print test results.\n[compact] (default) A single line, updated continuously.\n[expanded] A separate line for each update.\n[json] A machine-readable format (see https://dart.dev/go/test-docs/json_reporter.md).\n(defaults to \"compact\")", |
Author
There was a problem hiding this comment.
Thanks for pointing out. Removed in latest commit 👏
added 4 commits
March 20, 2021 12:17
Contributor
|
Thanks for making the changes! This was a big PR so thanks for the awesome contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Flutter 2.0.1 command autocompletion is not implemented yet
What is the new behavior (if this is a feature change)?
Add Flutter 2.0.1 command autocompletion
Additional info:
None