Skip to content

Improve MariaDB detection - #246

Merged
swissspidy merged 17 commits into
mainfrom
fix/mariadb-support
Mar 28, 2025
Merged

Improve MariaDB detection#246
swissspidy merged 17 commits into
mainfrom
fix/mariadb-support

Conversation

@swissspidy

@swissspidy swissspidy commented Mar 27, 2025

Copy link
Copy Markdown
Member

To-do: correctly set WP_CLI_TEST_DBTYPE=mariadb in https://github.com/wp-cli/.github

@swissspidy swissspidy added the scope:testing Related to testing label Mar 27, 2025
@codecov

codecov Bot commented Mar 27, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Context/FeatureContext.php 0.00% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mrsdizzie

Copy link
Copy Markdown
Member

All tests passing now. This requires the latest version of wp-cli/wp-cli#6072

I temporarily updated composer.json here but that probably needs to be undone before merging.

I added $this->variables['MYSQL_BINARY'] = $mysql_binary; to be used in behat tests (examples in the linked pr).

@swissspidy
swissspidy marked this pull request as ready for review March 28, 2025 08:02
@swissspidy
swissspidy requested a review from a team as a code owner March 28, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants