Skip to content

added namespace to avoid name collision - #16

Merged
yuce merged 3 commits into
yuce:masterfrom
girishramnani:master
Aug 3, 2019
Merged

added namespace to avoid name collision#16
yuce merged 3 commits into
yuce:masterfrom
girishramnani:master

Conversation

@girishramnani

Copy link
Copy Markdown
Contributor

base32 is a very common module name due to which at times a module name conflict occurs ( happened in my project ). So added pot_ prefix to base32 module

@coveralls

coveralls commented Aug 3, 2019

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 25

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.872%

Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 138
Relevant Lines: 141

💛 - Coveralls

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.872%

Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 138
Relevant Lines: 141

💛 - Coveralls

@yuce

yuce commented Aug 3, 2019

Copy link
Copy Markdown
Owner

Thanks for your contribution. It seems Travis CI doesn't support OTP 18.3 anymore, so CI fails. Could you remove it from .travis.yml and add your name to CONTRIBUTORS ?

@girishramnani

Copy link
Copy Markdown
Contributor Author

sure, changing

@girishramnani

Copy link
Copy Markdown
Contributor Author

done @yuce

@yuce

yuce commented Aug 3, 2019

Copy link
Copy Markdown
Owner

Thanks!

@yuce
yuce merged commit cc23e30 into yuce:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants