Repository navigation
PyPy's resolvedPyPyVersion has a trailing newline #609
Description
Description:
While working on #606 I discovered that PyPy's resolvedPyPyVersion contains a trailing newline, which causes the pythonVersion (passed to cacheDependencies) to look like 7.3.11\n-3.9.16.
Action version:
I'm running code against the main branch. The bug only exists on Ubuntu and macOS runners. The Windows runner does not have the trailing newline.
Platform:
- Ubuntu
- macOS
- Windows
Runner type:
- Hosted
- Self-hosted
Tools version:
PyPy 7.3.11 with Python 3.9.16
Repro steps:
You can see the issue in the output of the "Installed versions" output group. I've created a repo to demonstrate the issue with a simple workflow:
https://github.com/kurtmckee/demonstrate-pypy-newlines/actions/runs/4151696169/jobs/7182162044
Expected behavior:
I expect that the resolvedPyPyVersion variable will not have a trailing newline.
Actual behavior:
resolvedPyPyVersion has a trailing newline, and this can be seen in the "Installed versions" output group's text:
On Ubuntu and macOS:
Successfully set up PyPy 7.3.11
with Python (3.9.16)
On Windows:
Successfully set up PyPy 7.3.11 with Python (3.9.16)
Activity
kurtmckee commentedon Feb 11, 2023
I'm working to resolve this now and will open a PR shortly.
Trim trailing newlines from `resolvedPyPyVersion`
e-korolevskii commentedon Feb 13, 2023
Hello @kurtmckee! Thank you for reporting this!
We will investigate the issue and get back to you as soon as we have updates.
kurtmckee commentedon Feb 13, 2023
Thanks @e-korolevskii! I think I've fixed this in PR #610. Please take a look when you have an opportunity. 😀
Trim trailing newlines from `resolvedPyPyVersion` (#610)
dmitry-shibanov commentedon Feb 20, 2023
Hello @kurtmckee. We've merged your pull request. Could you please try to use setup-python as
actions/setup-python@mainto confirm that everything works as expected? Later we'll prepare the release and update the major tag.kurtmckee commentedon Feb 20, 2023
Will do! I'll report back shortly.
kurtmckee commentedon Feb 20, 2023
I've tested this against
actions/setup-python@mainand the bug is indeed fixed. Thank you all very much for the quick review and merge!Before
[link]
After
[link]
dmitry-shibanov commentedon Feb 20, 2023
Hello @kurtmckee. Thank you for your response. For now I'll reopen the until the new version is released.
kurtmckee commentedon Sep 15, 2023
The fix was released in v4.6.0. Closing.
Trim trailing newlines from `resolvedPyPyVersion` (actions#610)