Default connection pool is poorly configured in ApacheHttpTransport. Oauth2 library #1060

Activity

1. bit-twit commented on Nov 10, 2017

   

   bit-twit

   on Nov 10, 2017

   Last edited by bit-twit

   More actions

   I'm just posting this for other people that encounter this error and need a quick solution.

   Example of custom HTTP client implementation that can be used with google api.
   We use it to get rid of org.apache.http.NoHttpResponseException.

   One mention: this is no optimized for high traffic - for high traffic Apache HC suggests to actually catch error and retry if you consider appropiate.
   Link: Apache HTTP Client docs

   /**
    * Apache HTTP client implementation with:
    * - custom short Keep Alive policy
    * - supports 'retry once' policy
    * - has low number of connections
    * - has stale checking enabled
    */
   public class CustomTimeoutHttpClient {
       public static HttpClient newHttpClient() {
           return newDefaultHttpClient(
               SSLSocketFactory.getSocketFactory(), newDefaultHttpParams(), ProxySelector.getDefault());
       }
   
       /** Returns a new instance of the default HTTP parameters we use. */
       static HttpParams newDefaultHttpParams() {
           HttpParams params = new BasicHttpParams();
           // Turn off stale checking. Our connections break all the time anyway,
           // and it's not worth it to pay the penalty of checking every time.
           HttpConnectionParams.setStaleCheckingEnabled(params, true);
           HttpConnectionParams.setSocketBufferSize(params, 8192);
           ConnManagerParams.setMaxTotalConnections(params, 10);
           ConnManagerParams.setMaxConnectionsPerRoute(params, new ConnPerRouteBean(5));
           return params;
       }
   
       /**
        *
        * @param socketFactory SSL socket factory
        * @param params HTTP parameters
        * @param proxySelector HTTP proxy selector to use {@link ProxySelectorRoutePlanner} or
        *        {@code null} for {@link DefaultHttpRoutePlanner}
        * @return new instance of the Apache HTTP client
        */
       static DefaultHttpClient newDefaultHttpClient(
           SSLSocketFactory socketFactory, HttpParams params, ProxySelector proxySelector) {
           // See http://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html
           SchemeRegistry registry = new SchemeRegistry();
           registry.register(new Scheme("http", PlainSocketFactory.getSocketFactory(), 80));
           registry.register(new Scheme("https", socketFactory, 443));
           ClientConnectionManager connectionManager = new ThreadSafeClientConnManager(params, registry);
           DefaultHttpClient defaultHttpClient = new DefaultHttpClient(connectionManager, params);
           defaultHttpClient.setHttpRequestRetryHandler(new DefaultHttpRequestRetryHandler(1, true));
           if (proxySelector != null) {
               defaultHttpClient.setRoutePlanner(new ProxySelectorRoutePlanner(registry, proxySelector));
           }
           defaultHttpClient.setKeepAliveStrategy(new ShortKeepAliveStrategy());
           return defaultHttpClient;
       }
   
       public static class ShortKeepAliveStrategy implements ConnectionKeepAliveStrategy {
   
           @Override
           public long getKeepAliveDuration(HttpResponse response, HttpContext context) {
               // Keep alive for 5 seconds only
               return 5 * 1000;
           }
       }
   }
   
   

   👍React with 👍6Reacted by Dexter Legaspi, Dennis Neufeld, Chen Jian, Sergey Bukharov, Charles John and Mark Kolich
2. mattwhisenhunt

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   on Jan 8, 2018
3. kubukoz commented on Feb 14, 2018

   

   kubukoz

   on Feb 14, 2018

   More actions

   Just hit it, confirmed that it happens after a long time of not using the connection.
4. JustinBeckwith

   added

   🚨This issue needs some love.This issue needs some love.

   on Jun 8, 2018
5. chingor13

   removed

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   on Dec 18, 2018
6. JustinBeckwith

   removed

   🚨This issue needs some love.This issue needs some love.

   on Dec 18, 2018
7. chenjianjx commented on Mar 2, 2019

   

   chenjianjx

   on Mar 2, 2019

   More actions

   When will this be fixed in this open source project? Any ETA ?

   👍React with 👍4Reacted by Marten Richert, ciprian197, Andrey Gorbachev and Saggi Mizrahi
8. meltsufin

   added

   priority: p4

   on Dec 2, 2022