Repository navigation
Nominating @RichardLau for Releasers team #585
Description
Socialised via email to the @nodejs/tsc as per:
Release authorization is given by the Node.js TSC.
Reacted by Michaël Zasso, Ruben Bridgewater, Matteo Collina, Ruy Adorno and Shelley Vohr
Reacted by Richard Lau, Matteo Collina, Ruy Adorno and Shelley Vohr
Activity
MylesBorins commentedon Jun 10, 2020
+1!!!
mcollina commentedon Jun 10, 2020
+1
codebytere commentedon Jun 11, 2020
+1!
mhdawson commentedon Jun 15, 2020
+1
doc: add @richardlau to releasers
BethGriggs commentedon Jun 19, 2020
Raised #588 and added to the team.@richardlau, it is worth running through the 'Who Can Make A Release?' section. Please let me know if there is any access that requires someone with admin permissions to grant.
I'm also assuming you do not yet have access to https://github.com/nodejs-private/node-private for security releases. I do not know the process of adding releasers to that organisation. Can anyone from @nodejs/releasers confirm it is just a case of inviting Richard to the GitHub organisation and relevant teams?
richardlau commentedon Jun 19, 2020
@BethGriggs According to the process in https://github.com/nodejs/Release/blob/master/GOVERNANCE.md being added to the team happens after preparing a release? Or maybe the ordering doesn't matter if there are no objections (in which case we should update the docs)?
I can confirm I currently do not have access to https://github.com/nodejs-private/node-private.
FWIW I've been trying to add my gpg key to the public keyservers (via the submission link in https://github.com/nodejs/node/blob/master/doc/guides/releases.md#3-a-publicly-listed-gpg-key) but so far haven't been able to retrieve it via the command.
BethGriggs commentedon Jun 19, 2020
Converted #588 back to a draft and hold off with accesses until the first release is prepared.
I think the wording can be improved, as the following implied to me that the new releaser would kick off the builds (which you need to be in the release team for). Although, I think you have ci-release access via the Build WG anyway.
It would probably also be worth refactoring releases.md or adding a reference back to the Release governance documentation as they seem to overlap.
There are probably enough commits and backports to warrant preparing a v10.x release.
nschonni commentedon Jun 19, 2020
https://github.com/nodejs/docker-node/blob/master/keys/node.keys probably also needs to be updated, but I didn't see that in the release.md.
richardlau commentedon Jun 19, 2020
It’s listed in https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers. As @BethGriggs said it’s probably worth refactoring release.md.
keys: add key for @richardlau
doc: add release key for Richard Lau
doc: add release key for Richard Lau
doc: add release key for Richard Lau
doc: add @richardlau to releasers (#588)
doc: add release key for Richard Lau
doc: add release key for Richard Lau
doc: add release key for Richard Lau
doc: add @richardlau to releasers (#588)