Repository navigation
fixing incorrect 4.4.4.4 DNS reference(s) in examples #41803
Description
Affected URL(s)
https://nodejs.org/api/dns.html#dnspromisesreverseip
Description of the problem
fixing incorrect 4.4.4.4
to (what I assume) should be 8.8.8.8/8.8.4.4/dns.google (Google DNS 1 2 3).
note
not sure what the source of this mistake is
(I think it was an old Verizon name server),
but I see this a lot and not just in n00b codes,
but in big a$$ companies as well..
in most cases running the code in the example will just render a timeout (and a puzzled developer),
in other cases (silent fallback..) it may go through the os default name resolving chain which will render some unexpected results and be somewhat challenging to debug.. :|
edit:
IP address ranges that are designated for use in documentation 1I would prefer a working example.
edit:
- https://github.com/features/code-search/signup
- https://cs.github.com/?scopeName=All+repos&scope=&q=repo%3Anodejs%2Fnode+%224.4.4.4%22
Activity
maruf061 commentedon Feb 1, 2022
Thanks for sharing
tniessen commentedon Feb 1, 2022
It is indeed strange that the IPv6 address seems to point to Google but the IPv4 does not. On the other hand, these are just meant as an example and we don't want to push users toward using any specific company's DNS provider. (Putting my Cloudflare hat on:
1.1.1.1is faster than8.8.8.8.) There are IP address ranges that are designated for use in documentation that we could use.Users should only call
setServersif they have a good reason not to use the system's DNS resolver settings.