Repository navigation
http2: content-encoding is incorrectly listed in kSingleValueHeaders #67151
Description
Version
v26.13.0
Platform
Subsystem
No response
What steps will reproduce the bug?
Drafted by Gemini 4 Argon.
In lib/internal/http2/util.js, HTTP2_HEADER_CONTENT_ENCODING is listed in kSingleValueHeaders:
- Incoming (
mapToHeaders): When an HTTP/2 peer sends multiplecontent-encodingheader lines (e.g.,content-encoding: gziptwice on Google Drive viewer endpoints), only the first value is kept inheaders['content-encoding']and subsequent values are silently dropped (even withstrictSingleValueFields: falsefrom http2: add strictSingleValueFields option to allow relaxing header validation #59917). As a result, HTTP/2 clients only decompress the first layer and treat the still-compressed payload as decoded data, and reverse proxies forwardingheadersstrip the remaining encoding layers so downstream browsers fail to decode the response. - Outgoing (
buildNgHeaderString): Passing multiplecontent-encodingvalues throwsERR_HTTP2_HEADER_SINGLE_VALUEby default, preventing servers and proxies from sending or forwarding multi-valuecontent-encodingheaders.
Evidence
-
HTTP Semantics — RFC 9110 §8.4 (
Content-Encoding) & §5.3:Content-Encoding = #content-codingIf one or more encodings have been applied to a representation, the sender that applied the encodings MUST generate a Content-Encoding header field that lists the content codings in the order in which they were applied.
Because
Content-Encodinguses the#elementlist ABNF production, multiplecontent-encodingheader field lines are valid per RFC 9110 §5.3 and must be combined in order with', 'rather than discarded. -
HTTP/2 & HPACK — RFC 9113 §8.2.1 & RFC 7541:
HTTP/2 only forbids connection-specific headers (connection,transfer-encoding,keep-alive,upgrade,proxy-connection); for all other fields, RFC 9113 §8.2.1 inherits RFC 9110 §5.3, allowing list-based headers to be transmitted as multiple separate HPACK header field entries (each referencing HPACK static table index 26content-encoding).nghttp2itself accepts multiplecontent-encodingentries and delivers all of them inrawHeaders—the truncation happens purely in Node's JSkSingleValueHeaderscheck. -
node:httpconsistency:lib/_http_incoming.js(_addHeaderLine) does not treatcontent-encodingas single-value and joins duplicate lines with', '.
Removing HTTP2_HEADER_CONTENT_ENCODING from kSingleValueHeaders fixes both directions.
Compatibility
- No type change:
headers['content-encoding']remainsstring | undefined(mapToHeadersjoins non-single-value headers with', '), and singlecontent-encodingresponses are unaffected. - Incoming duplicate headers:
headers['content-encoding']becomes'gzip, br'instead of'gzip'(matching what a singlecontent-encoding: gzip, brheader ornode:httpalready produces). Callers doing exact single-token checks (headers['content-encoding'] === 'gzip') without splitting on','may stop matching when a peer sends multiple lines. - Outgoing validation: Passing multiple
content-encodingvalues will succeed instead of throwingERR_HTTP2_HEADER_SINGLE_VALUE(potentiallysemver-majorper Node's error-removal policy).
How often does it reproduce? Is there a required condition?
What is the expected behavior? Why is that the expected behavior?
What do you see instead?
Additional information
No response
Activity