Repository navigation
ResourceLoader.get_data() should accept a PathLike #76627
Description
| BPO | 32446 |
|---|---|
| Nosy | @warsaw, @brettcannon, @jayyyin |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2018-01-26.22:04:33.075>
created_at = <Date 2017-12-29.15:33:19.423>
labels = ['3.7']
title = 'ResourceLoader.get_data() should accept a PathLike'
updated_at = <Date 2018-01-26.22:04:33.074>
user = 'https://github.com/warsaw'bugs.python.org fields:
activity = <Date 2018-01-26.22:04:33.074>
actor = 'barry'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-26.22:04:33.075>
closer = 'barry'
components = []
creation = <Date 2017-12-29.15:33:19.423>
creator = 'barry'
dependencies = []
files = []
hgrepos = []
issue_num = 32446
keywords = []
message_count = 6.0
messages = ['309178', '310798', '310801', '310802', '310804', '310808']
nosy_count = 3.0
nosy_names = ['barry', 'brett.cannon', 'jayyin11043']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue32446'
versions = ['Python 3.7']
Activity
warsaw commentedon Dec 29, 2017
Currently get_data() only accepts a string. It should also accept a os.PathLike
jayyyin commentedon Jan 26, 2018
I'm taking a look now, this looks interesting
jayyyin commentedon Jan 26, 2018
this would extend to set and get data right?, also would it be good to use the current get_data() (one that reads only string) function for the overloaded one and extract the string path from the os.path object? or would we want the os.path object to be handled separately?
jayyyin commentedon Jan 26, 2018
nvm I temporarily forgot I was working with python here, I'd need to use "is" to check what the entered "path" is huh?
jayyyin commentedon Jan 26, 2018
I hope this isn't a dumb question but where is ResourceLoader.get_data() implemented, using ATOM to search the whole project and I can't seem to find it.
warsaw commentedon Jan 26, 2018
Hi Jay. Thanks for your interest in contributing to Python!
Actually, I'm going to close this issue since we ultimately decided to deprecate the ResourceLoader ABC:
https://docs.python.org/3.7/library/importlib.html?highlight=resourceloader#importlib.abc.ResourceLoader
I'd also suggest that if you're interested in answering your questions for the curiosity, or want to contribute to Python in other areas, you should join the python-dev mailing list.