Repository navigation
Some "truthy/falsy" crept in #95454
Description
Python consistently says true/false, not truthy/falsy. But a few "truthy/falsy" crept into the logging docs:
https://github.com/python/cpython/search?q=truthy
https://github.com/python/cpython/search?q=falsy
(Previous issue about a previous instance)
Activity
pythongh-95454: Replaced truthy/falsy with true/false
pythongh-95454: Remove truthy with true
pythongh-95454: change NEWS doc
gh-95454: Replace truthy/falsy with true/false (GH-95456)
PurityLake commentedon Jul 30, 2022
This can probably be closed now unless I missed some.
pochmann commentedon Jul 30, 2022
@PurityLake The above search for falsy still finds a few in
Lib/test/test_except_star.py(not sure if intentional ... in the previous issue, rhettinger also left some in test code and only fixed the docs (which is why above I only spoke of the docs), but it looks like you tried to fix truly all).PurityLake commentedon Jul 30, 2022
@pochmann maybe I was a little over zealous, hasn't seemed to affect the functionality at least, I'll make another PR to squash that last one. Seemed Raymond was the one to commit the changes so he must not have minded.
rhettinger commentedon Jul 30, 2022
IMO the PR was too aggressive. I approved it only because it wasn't worth the time to debate each individual case. Let's be done with this one now.
PurityLake commentedon Jul 30, 2022
Apologies, I'll be more diligent in future