ES6hasInstance - #1063
Merged
Merged
Conversation
Author
|
@Microsoft/chakra-es could you take a look pls? |
Contributor
| var x = proxy.bind(); | ||
| print((x) instanceof proxy); | ||
| } | ||
| testRunner.runTests(tests, { verbose: WScript.Arguments[0] != "summary" }); |
Contributor
There was a problem hiding this comment.
Please run test262 to see if there any additional failures in Symbol.hasInstance
Author
There was a problem hiding this comment.
Contributor
|
|
Author
Recuperate perf loss from existing ES6hasInstance implementation. Perf-neutral with vs. without -es6hasinstance switch. Add inline-cache-invalidation for user-defined Symbol.hasInstance property in function constructor. Revamp unit tests for ES6hasInstance. Related ECMA262 spec sections: 6.1.5.1 Well-Known Symbols 7.3.19 OrdinaryHasInstance (C, O) 12.10.4 Runtime Semantics: InstanceofOperator(O, C) 19.2.3.6 Function.prototype [ @@hasInstance ] ( V )
chakrabot
pushed a commit
that referenced
this pull request
Jun 9, 2016
Merge pull request #1063 from suwc:build/suwc/buddy Recuperate perf loss from existing ES6hasInstance implementation. Perf-neutral with vs. without -es6hasinstance switch. Add inline-cache-invalidation for user-defined Symbol.hasInstance property in function constructor. Revamp unit tests for ES6hasInstance. Related ECMA262 spec sections: 6.1.5.1 Well-Known Symbols 7.3.19 OrdinaryHasInstance (C, O) 12.10.4 Runtime Semantics: InstanceofOperator(O, C) 19.2.3.6 Function.prototype [ @@hasInstance ] ( V )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recuperate perf loss from existing ES6hasInstance implementation.
Perf-neutral with vs. without -es6hasinstance switch.
Add inline-cache-invalidation for user-defined Symbol.hasInstance property in function constructor.
Revamp unit tests for ES6hasInstance.
Related ECMA262 spec sections:
6.1.5.1 Well-Known Symbols
7.3.19 OrdinaryHasInstance (C, O)
12.10.4 Runtime Semantics: InstanceofOperator(O, C)
19.2.3.6 Function.prototype @@hasInstance