Skip to content

feat: add support for SapMachine JDK/JRE - #614

Merged
v-HarithaVattikuti merged 2 commits into
actions:mainfrom
Shegox:main
Sep 5, 2024
Merged

feat: add support for SapMachine JDK/JRE#614
v-HarithaVattikuti merged 2 commits into
actions:mainfrom
Shegox:main

Conversation

@Shegox

@Shegox Shegox commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

Description:
This PR adds support for setting up the SapMachine JDK/JRE using the setup-java action.
The implementation is heavily inspired by the dragonwell implementation.
The setup-java supports setting up SapMachine for JRE and JDK for following operating systems/architectures:

  • macos (arm/x86)
  • linux (arm/x86)
  • linux-muse (x86) (for alpine containers)
  • windows (x86)

The releases URL https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json, which is used to determine the download URL, contains the up-to-date full list of all SapMachine JDKs and JREs.

Otherwise this PR adds 21 to the list of major e2e tested versions for all releases, which works for all. If you want I can as well add it to a separate PR.

Related issue:
fixes #72
fixes SAP/SapMachine#821

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Tested additionally via:

@Shegox
Shegox requested a review from a team as a code owner March 27, 2024 14:09
Co-authored-by: Christian Schwaninger <christian.schwaninger@sap.com>

@RealCLanger RealCLanger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Thank you for doing this.

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams

ghost commented Apr 10, 2024

Copy link
Copy Markdown
Member

@aparnajyothi-y can we get a review of this PR please

@joergmann

ghost commented Apr 16, 2024

Copy link
Copy Markdown

great!

@rjayasinghe

ghost commented Apr 18, 2024

Copy link
Copy Markdown

Great! Go for it! 💚

@RealCLanger

ghost commented May 6, 2024

Copy link
Copy Markdown
Contributor

@HarithaVattikuti can you take a look?

@RealCLanger

ghost commented May 6, 2024

Copy link
Copy Markdown
Contributor

@priyagupta108 can you take a look?

@RealCLanger

ghost commented May 7, 2024

Copy link
Copy Markdown
Contributor

@mahabaleshwars Could you take a look here or give us some ETA for when this can be merged? We have quite some folks waiting for this... Thanks

@fniephaus

ghost commented May 7, 2024

Copy link
Copy Markdown
Contributor

@RealCLanger #501 is stuck in a similar fashion: no response from the maintainers for months. I was told they need their lawyers to review the license of the JDK distro to ensure the distro can be integrated into this action. We went through this with them when adding Oracle JDK (#401), but somehow it now seems that process is stuck indefinitely.

@RealCLanger

ghost commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

@stoe Could you find out something about the progress of this already?

@aparnajyothi-y

ghost commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Hello Everyone, We have prioritized the feature request to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR. We will update you once we have some feedback.

@fniephaus fniephaus mentioned this pull request Jul 23, 2024
2 tasks
@RealCLanger

ghost commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Hello Everyone, We have prioritized the feature request for this Q4 to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR for the feature request. We will update you once we have some feedback.

Thanks for the update. So let's hope this can be integrated by Q4 or even sooner... 😄

@skateball

ghost commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Hello Everyone, We have prioritized the feature request to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR. We will update you once we have some feedback.

@aparnajyothi-y Hi, can you please give an update how long this will take?
Can we help/assist you in any way to get this PR sooner solved?
Best Regards Christian

@RealCLanger

ghost commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Any updates (@aparnajyothi-y) ?

@aparnajyothi-y

ghost commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Hello Everyone, we are in the process of reviewing this PR. We will update once the review completed.

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How long does it take that I know when to organize cake?

@v-HarithaVattikuti
v-HarithaVattikuti merged commit 7467385 into actions:main Sep 5, 2024
@Shegox Shegox mentioned this pull request Oct 15, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github action for SapMachine Add support for SapMachine binaries