feat: add support for SapMachine JDK/JRE - #614
Conversation
Co-authored-by: Christian Schwaninger <christian.schwaninger@sap.com>
RealCLanger
left a comment
There was a problem hiding this comment.
Great stuff. Thank you for doing this.
commented
Apr 10, 2024
|
@aparnajyothi-y can we get a review of this PR please |
commented
Apr 16, 2024
|
great! |
commented
Apr 18, 2024
|
Great! Go for it! 💚 |
commented
May 6, 2024
|
@HarithaVattikuti can you take a look? |
commented
May 6, 2024
|
@priyagupta108 can you take a look? |
commented
May 7, 2024
|
@mahabaleshwars Could you take a look here or give us some ETA for when this can be merged? We have quite some folks waiting for this... Thanks |
commented
May 7, 2024
|
@RealCLanger #501 is stuck in a similar fashion: no response from the maintainers for months. I was told they need their lawyers to review the license of the JDK distro to ensure the distro can be integrated into this action. We went through this with them when adding Oracle JDK (#401), but somehow it now seems that process is stuck indefinitely. |
commented
Jul 23, 2024
|
@stoe Could you find out something about the progress of this already? |
|
Hello Everyone, We have prioritized the feature request to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR. We will update you once we have some feedback. |
commented
Jul 23, 2024
Thanks for the update. So let's hope this can be integrated by Q4 or even sooner... 😄 |
commented
Aug 5, 2024
@aparnajyothi-y Hi, can you please give an update how long this will take? |
commented
Sep 2, 2024
|
Any updates (@aparnajyothi-y) ? |
commented
Sep 2, 2024
|
Hello Everyone, we are in the process of reviewing this PR. We will update once the review completed. |
Description:
This PR adds support for setting up the SapMachine JDK/JRE using the setup-java action.
The implementation is heavily inspired by the dragonwell implementation.
The setup-java supports setting up SapMachine for JRE and JDK for following operating systems/architectures:
The releases URL
https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json, which is used to determine the download URL, contains the up-to-date full list of all SapMachine JDKs and JREs.Otherwise this PR adds
21to the list of major e2e tested versions for all releases, which works for all. If you want I can as well add it to a separate PR.Related issue:
fixes #72
fixes SAP/SapMachine#821
Check list:
Tested additionally via: