[Bug] Form element type icons linked to external library

[julianmka]

Short description of the bug

The icon component used for form element types is linked to an external library rather than being an internal component.

More details about the bug

The icons for form element annotations are not internal to the annotation kit. When I try to visit the main component, I get an error that I don't have access.

This isn't a blocker, but having access to the icon component and being able to update them as internal components would be nice.

Alt text

• My images use descriptive alt text.

Code of Conduct

• I agree to follow this project's Code of Conduct

[janmaarten-a11y]

@julianmka 👋🏼 ❤️ Good catch!

The external library (originally) was Primer's Octicons, but I've been trying to flatten them to reduce dependencies. Found one instance that I missed in the Form elements > Radio icon itself. I also found that six of the Form Element Details variants (Range, Email, Number, Phone, Date, Time) were all pulling the wrong icon instances. Both will be corrected in the next patch. 🙌🏼 Are you seeing it elsewhere?

I also did a scan of the full library to find other external components. I found some similar regressions in Mobile lasso particles, Mobile details, Language details and Cursors. All of those will be fixed too.

I think a bunch of these happened because we had to duplicate the library at the last minute before publishing it to the public, and a bunch of bits and pieces were pointing to the old file. There are a bunch of others from Octicons and Primer Web that I'm not concerned about since those aren't library assets.

[julianmka]

I will do a more thorough review, but your update generally follows what I found.

[julianmka]

Was doing more cleanup in my file yesterday and found some more external references:

• external type style used in the Out of Scope component (h/t Rachele DiTullio)
• external icon component referenced in the basic note stamp icon variant
• external icon component referenced in all of the library note components (e.g. the "you can detach this" note)

[janmaarten-a11y]

@julianmka Good catch, y'all. 🫶

The external icon components reference our open source Octicon library, and I'm hesitant to change that. It makes it easy for our internal teams to swap instances to a preferred icon, but keeping it as a component should also make it relatively simple for external teams to swap in their own icon sets/libraries.

[julianmka]

Fair enough. I've gone ahead and just flattened the icons for the sake of ease. The teams I'm working with are not likely to swap out icons. Good to know I can grab the Octicons file if I need to in the future 😊

[janmaarten-a11y]

Fixed in v1.6.4. 🎉 The form element type icons and other components we found are now internal components, so you should have full access to view and update them. Let me know if you still hit any permission errors and we can reopen this.