Skip to content

Upgrade to oss-parent 9 - #2149

Merged
eamonnmcmanus merged 1 commit into
google:masterfrom
liutikas:patch-1
Jul 21, 2022
Merged

Upgrade to oss-parent 9#2149
eamonnmcmanus merged 1 commit into
google:masterfrom
liutikas:patch-1

Conversation

@liutikas

Copy link
Copy Markdown
Contributor

org.sonatype.oss:oss-parent:7 is unsigned (missing .asc files), which forces users of gson library
that enforce signature verification to explicitly allowlist oss-parent. Luckily oss-parent 9 is signed,
thus fixing this issue.

See:
https://repo1.maven.org/maven2/org/sonatype/oss/oss-parent/7/
vs
https://repo1.maven.org/maven2/org/sonatype/oss/oss-parent/9/

org.sonatype.oss:oss-parent:7 is unsigned (missing .asc files), which forces users of gson library
that enforce signature verification to explicitly allowlist oss-parent. Luckily oss-parent 9 is signed,
thus fixing this issue.

See:
https://repo1.maven.org/maven2/org/sonatype/oss/oss-parent/7/
vs
https://repo1.maven.org/maven2/org/sonatype/oss/oss-parent/9/
@jvirtanen

Copy link
Copy Markdown

This looks like a good change, but for the long term, it would be best to move away from oss-parent as it is deprecated and might not work correctly anymore.

@liutikas

Copy link
Copy Markdown
Contributor Author

This looks like a good change, but for the long term, it would be best to move away from oss-parent as it is deprecated and might not work correctly anymore.

I think that seems to be a fine thing to do, but I would prefer it is done in a separate step :)

@eamonnmcmanus

Copy link
Copy Markdown
Member

Thanks! I agree that ultimately we should get rid of oss-parent. I may try that before the next release, since I think the main impact is on releasing.

@eamonnmcmanus
eamonnmcmanus merged commit eeba71c into google:master Jul 21, 2022
@Marcono1234

Copy link
Copy Markdown
Contributor

Getting rid of oss-parent would be really good. It appears at the moment it apparently effectively downgrades certain plugins during release, which seems to be the reason why the published Javadoc has no external links to the JDK classes. The following is logged:

[INFO] --- maven-javadoc-plugin:2.7:jar (attach-javadocs) @ gson ---
[ERROR] Error fetching link: https://docs.oracle.com/en/java/javase/11/docs/api/package-list. Ignored it.
...

Notice the 2.7 as version even though Gson specifies 3.4.0 as version for that plugin (and a regular mvn package javadoc:javadoc works without issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants