Skip to content

Fix incorrect HTML headings in Javadoc - #2200

Merged
eamonnmcmanus merged 1 commit into
google:masterfrom
Marcono1234:marcono1234/html-headings
Sep 25, 2022
Merged

Fix incorrect HTML headings in Javadoc#2200
eamonnmcmanus merged 1 commit into
google:masterfrom
Marcono1234:marcono1234/html-headings

Conversation

@Marcono1234

Copy link
Copy Markdown
Contributor

Follow-up for #2198

It looks like in that pull request only the first incorrect heading was updated, but headings which should be at the same level were not updated, causing them to become sub-headings.

@Marcono1234
Marcono1234 force-pushed the marcono1234/html-headings branch from ef02584 to 82c0933 Compare September 24, 2022 22:43
@Marcono1234 Marcono1234 changed the title Fix incorrect HTML headings Fix incorrect HTML headings in Javadoc Sep 24, 2022
* most useful when several types share similar structure in their JSON form.
*
* <h2>Example: Converting enums to lowercase</h2>
* <h2>Examples</h2>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added a new parent heading here to group the examples a bit, I hope that is fine.

@eamonnmcmanus

Copy link
Copy Markdown
Member

Thanks, that looks great!

@eamonnmcmanus
eamonnmcmanus merged commit 2591ede into google:master Sep 25, 2022
@Marcono1234
Marcono1234 deleted the marcono1234/html-headings branch September 25, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants