Skip to content

Fix trace toggling for multiple vehicles - #4266

Merged
David Zimmermann (zimmy87) merged 3 commits into
microsoft:masterfrom
rajat2004:multi-vehicle-trace
Jan 12, 2022
Merged

Fix trace toggling for multiple vehicles#4266
David Zimmermann (zimmy87) merged 3 commits into
microsoft:masterfrom
rajat2004:multi-vehicle-trace

Conversation

@rajat2004

@rajat2004 Rajat Singhal (rajat2004) commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

Fixes: #4260

About

Now tracing gets enabled for all the vehicles
TODO

  • Cleanup of SimHUD code
  • Support tracing in Car vehicle (Possibly in a separate PR)

How Has This Been Tested?

Using the Pythonclient/multirotor/multi_agent_drone.py script and settings
Screenshot from 2022-01-04 07-34-39

Screenshots (if appropriate):

@rajat2004
Rajat Singhal (rajat2004) marked this pull request as ready for review January 4, 2022 18:50
@rajat2004

Copy link
Copy Markdown
Contributor Author

ZiMMy From #4274 looks like a new release is going to happen soon. Is it possible to have this PR included as well?

@zimmy87 David Zimmermann (zimmy87) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this this Rajat Singhal (@rajat2004)! Tested locally and this works for me just fine. Left one comment about cleaning up the Unity wrapper. Will talk with the team about whether to include this in the next release.

Comment on lines -37 to -38
ImageType getSubwindowCameraType(int window_index);
void setSubwindowCameraType(int window_index, ImageType type);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSubwindowCameraType, getSubwindowCameraType, getSubwindowVisible, and setSubwindowVisible are also defined here. Is there any reason to not clean up the Unity wrapper as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main reason was that I currently don't have a working Unity installation, going through that code, none of the subwindow code in Unity SimHUD.cpp seems to be actually used, and the subwindows are created in AirsimHUDScript.cs
Will try to go through it a bit more

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a working Unity installation, so I decided to commit this cleanup change after testing that subwindows still functioned normally in my Unity build. Once I get this merged, I'll include it in the next release.

remove unnecessary subwindow helper functions
@zimmy87

Copy link
Copy Markdown
Contributor

Thanks for submitting this PR Rajat Singhal (@rajat2004)! Moving ahead with merging.

@zimmy87
David Zimmermann (zimmy87) merged commit 0becf91 into microsoft:master Jan 12, 2022
@rajat2004
Rajat Singhal (rajat2004) deleted the multi-vehicle-trace branch January 12, 2022 10:56
@rajat2004

Copy link
Copy Markdown
Contributor Author

Thanks a lot David Zimmermann (@zimmy87) for the Unity changes! I'll get my old setup working over the weekend, sorry for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In multi-drone emulation, pressing T toggle Trace line only works on one drone

2 participants