Display notification when debugging without selecting a python interpreter - #2552
Merged
Don Jayamanne (DonJayamanne) merged 33 commits intoSep 12, 2018
Merged
Conversation
* master: Standardize interpreter display format (#2540)
Derek Keeler (d3r3kk)
approved these changes
Sep 12, 2018
Derek Keeler (d3r3kk)
left a comment
Derek Keeler (d3r3kk)
left a comment
There was a problem hiding this comment.
Please alter the implementation of IActiveInterpreter, but other than that this looks good.
3 tasks
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Sep 14, 2018
…#2588) Fixes #2587 (fixes bug introduced by #2552) * The `launch.json` can contain the value `$config:python.pythonPath}` as the value for the python path. We need to account for this value when validating the python path before debugging. * Also moved validation code into a separate method of the diagnostics class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2494
package.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)