Update snippet.md - #231790
Merged
Merged
Conversation
Missing parentheses in 3rd option for the nonterminal format in the EBNF for snippets.
Dmitriy Vasyura (dmitrivMS)
assigned
Dmitriy Vasyura (dmitrivMS) and unassigned
Johannes Rieken (jrieken)
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 23, 2026 20:57
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 23, 2026
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 23, 2026 20:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects the snippet EBNF to properly group format-transform alternatives.
Changes:
- Adds parentheses around case-conversion format options.
Show a summary per file
| File | Description |
|---|---|
src/vs/editor/contrib/snippet/browser/snippet.md |
Corrects grouping in the format grammar rule. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
roblourens
approved these changes
Aug 23, 2026
Ladislau Szomoru (lszomoru)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing parentheses in 3rd option for the nonterminal format in the EBNF for snippets.