fix: memory leak in PerfModelContentProvider - #328581
Merged
Connor Peet (connor4312) merged 1 commit intoAug 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes retained disposable wrappers when the Startup Performance model is recreated.
Changes:
- Reassigns
_modelDisposablestodispose()’s empty-array result. - Adds regression coverage for repeated model creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
perfviewEditor.ts |
Clears disposed model listeners. |
perfviewEditor.test.ts |
Verifies listener storage remains bounded. |
Connor Peet (connor4312)
enabled auto-merge
August 3, 2026 15:40
Don Jayamanne (DonJayamanne)
approved these changes
Aug 3, 2026
Anthony Kim (anthonykim1)
approved these changes
Aug 3, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/memory-leak-PerfModelContentProvider
branch
August 13, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When the Startup Performance text model is recreated, disposed language and extension-status listeners stay reachable because
_modelDisposableskeeps their disposable wrappers.Change
Use the empty array returned by
disposeso only listeners for the current model remain reachable.Before
When running
startup-performance-view-open37 times, the language selection and content-provider callbacks grow:After
No more matching leak is detected.
Test Video
startup-performance-view-open.webm