Support opening MHTML files in integrated browser - #333307
Merged
Joaquín Ruales (jruales) merged 2 commits intoSep 4, 2026
Merged
Conversation
Copilot started reviewing on behalf of
吉井 啓人（YOSHII, Hiroto） (YOSHII-Hiroto)
August 29, 2026 04:29
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Kyle Cutler (@kycutler)Matched files:
Joaquín Ruales (@jruales)Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the integrated browser’s local-file command to support MHTML archives.
Changes:
- Enables
.mhtand.mhtmlfiles alongside.htmand.html. - Applies support across existing Explorer and editor menu registrations.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 29, 2026
Copilot started reviewing on behalf of
Joaquín Ruales (jruales)
September 1, 2026 22:01
View session
Joaquín Ruales (jruales)
requested review from
Joaquín Ruales (jruales) and
Kyle Cutler (kycutler)
September 1, 2026 22:02
Kyle Cutler (kycutler)
approved these changes
Sep 3, 2026
Kyle Cutler (kycutler)
left a comment
Kyle Cutler (kycutler)
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thank you 吉井 啓人（YOSHII, Hiroto） (@YOSHII-Hiroto)!
Joaquín Ruales (jruales)
approved these changes
Sep 4, 2026
Joaquín Ruales (jruales)
enabled auto-merge (squash)
September 4, 2026 07:13
Christof Marti (chrmarti)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.mhtmland.mhtto the local file extensions supported by Open in Integrated Browser. Chromium already renders MHTML archives, including pages saved with Save page as... using Webpage, single file (*.mhtml), so this reuses the existing local-file browser flow.The command is now available from the Explorer context menu, editor tab context menu, and editor title actions for both extensions.
Testing:
npx eslint src/vs/workbench/contrib/browserView/electron-browser/features/browserTabManagementFeatures.tsnpm run transpile-clientgit diff --check upstream/main...HEAD.mhtand.mhtmlcommand visibility in all three UI locationsFixes #333305