[stable-34.0] feat(tray): Migrate TrayWindow to the new tray user menu - #10321
Merged
Conversation
Consolidates the tray account status menu work and related follow-up fixes into one reviewable commit. Assisted-by: Codex:gpt-5 Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
will make maintenance easier Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Co-authored-by: Iva Horn <iva.horn@nextcloud.com> Signed-off-by: Rello <Rello@users.noreply.github.com>
almost always use enum class to get more strict checks by compiler use missing Qt macro definitions for better bindings Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
return values of Qt slots are ignored it was never checked by callers Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
rowCount in a flat mdoel shoudl return 0 for every parent that is valid otherwise, views may think that the menu has child items for every existing items also do not add not needed count method (reuse existing rowCount) Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Rello <github@scherello.de>
Remove hardcoded sizes, radius and margins, use Style properties instead. Extract the shared window flags, palette and background of the wizard window into a new WizardStyledWindow base component. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
The role enumerators were declared as a scoped enum (enum class) while the tray popup call sites used the unscoped form and relied on implicit int conversion, which broke the macOS build. Switch to an unscoped enum so the enumerators live in class scope and convert to int, matching the call sites and the sibling role enums, and drop the now-redundant casts. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
The role range guard used role < IconUrlRole, which excluded IconUrlRole itself, so case IconUrlRole was unreachable and data() returned an empty QVariant for it. As a result the account apps popup never received app icon URLs. Use <= so the icon role is served. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Rello <github@scherello.de>
…code files and added documentation Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
backportbot
Bot
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
July 8, 2026 12:05
backportbot
Bot
added
os: 🍎 macOS
Rello
approved these changes
Jul 8, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10321.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10164