Bugfix/better handling of locked files during upload - #9566
Merged
Conversation
mgallien
requested review from
Aiiaiiio,
camilasan,
i2h3 and
nilsding
as code owners
March 4, 2026 15:12
mgallien
force-pushed
the
bugfix/betterHandlingOfLockedFilesDuringUpload
branch
from
March 4, 2026 15:24
eaabcb5 to
92ff52f
Compare
Collaborator
Author
|
possibly related #6131 |
nilsding
approved these changes
Mar 9, 2026
mgallien
force-pushed
the
bugfix/betterHandlingOfLockedFilesDuringUpload
branch
from
March 10, 2026 09:59
92ff52f to
6c986e9
Compare
Collaborator
Author
|
/backport to stable-33.0 |
mgallien
enabled auto-merge
March 10, 2026 13:52
better version of FileSystem::isLockedFile taken over from https://github.com/owncloud/client/blob/master/src/common/filesystembase.cpp#L482 adapted our existing code to work with it Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should prevent critical errors from being reported about a failing network job while it is only the source file being locked Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/betterHandlingOfLockedFilesDuringUpload
branch
from
March 10, 2026 13:52
6c986e9 to
98acc88
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9566.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Collaborator
Author
|
/backport to stable-4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #9111