MAINT: exit deadlock tests quickly on slow hardware - #32466
Merged
Conversation
ngoldbaum
added
03 - Maintenance
09 - Backport-Candidate
vividwhisp
reviewed
Sep 1, 2026
vividwhisp
left a comment
vividwhisp
left a comment
There was a problem hiding this comment.
hey @ngoldbaum i'm new here!
any tips to get started with contributing like in pytests, etc.
mattip
approved these changes
Sep 1, 2026
mattip
left a comment
mattip
left a comment
Member
There was a problem hiding this comment.
LGTM. One suggestion, feel free to ignore.
Co-authored-by: Matti Picus <matti.picus@gmail.com>
ngoldbaum
force-pushed
the
fix-slow-emulated-test
branch
from
September 1, 2026 20:40
d872632 to
73592df
Compare
charris
pushed a commit
that referenced
this pull request
Sep 2, 2026
Co-authored-by: Matti Picus <matti.picus@gmail.com>
charris
added a commit
that referenced
this pull request
Sep 2, 2026
MAINT: exit deadlock tests quickly on slow hardware (#32466)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
See #32461.
@h-vetinari mentioned that he has some tests that use this helper skipped for riscv and ppc on conda-forge because they take longer than 30 seconds and lead to test failures.
Rather than skipping these tests, let's add a second way for these tests to exit if no deadlock happens.
On a fast machine, these tests all pass in less than a second. On a slow machine, we're still testing for deadlocks, but we don't spend 30 seconds chewing on contended memory and instead exit if we're still making forward progress after 2 seconds. We'll never reach the
breakif there's a deadlock so a real deadlock will still hit the 30s timeout.AI Disclosure
I used an AI to think about the problem. I implemented the fix.