fix: sanitize escape sequence injection - #1976
Merged
Merged
Conversation
tmccombs
requested changes
Apr 20, 2026
tavianator
reviewed
May 1, 2026
tavianator
reviewed
May 2, 2026
tavianator
reviewed
May 2, 2026
added 2 commits
May 2, 2026 20:52
tmccombs
approved these changes
May 5, 2026
tmccombs
left a comment
tmccombs
left a comment
Collaborator
There was a problem hiding this comment.
Would you mind adding an entry to the changelog?
added 2 commits
May 5, 2026 21:27
tmccombs
approved these changes
May 5, 2026
added 2 commits
May 17, 2026 20:35
Author
|
Is there anything left to do for the merge? |
|
It looks like this PR removed jemalloc from the default features. I don't see any references to this happening so it appears to have been accidental? Note that this has leaked into the 10.5.0 release too. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filenames can contain terminal escape codes (like ESC). fd prints them raw to your terminal, so a file named
innocent\x1b]52;c;...\x1b\.txtsilently rewrites your clipboard. Fix: strip control bytes before writing to a TTY.fd -x rm {/}in a dir with a file named -rf runsrm -rf. Fix: prepend ./ when a path placeholder produces a leading dash.fd -x '{}'lets you use {} as the command to run, not just an argument to one. It's inconsistent with fd -X which rejects this. The patch rejects placeholder in args[0] for both modes.Also added tests to ensure changes don't break this in the future