Skip to content

xfd, tag: add "desired outcome" dropdown (with delete, merge, redirect, draftify), and remove {{Merge}} tags from tag module - #2345

Merged
NovemLinguae merged 23 commits into
masterfrom
afd-merge-3
Apr 27, 2026
Merged

xfd, tag: add "desired outcome" dropdown (with delete, merge, redirect, draftify), and remove {{Merge}} tags from tag module#2345
NovemLinguae merged 23 commits into
masterfrom
afd-merge-3

Conversation

@NovemLinguae

@NovemLinguae NovemLinguae commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Why

  • a recent RFC decided to bring the merging process into the AFD process

What

  • xfd module
    • add dropdown called "Desired outcome:" with options Delete, Merge, Redirect, and Draftify
    • sometimes add text box "Target page:" depending on what is chosen in the dropdown
    • for merging, when a target page is provided, add a {{Merge from}} tag to the target page
    • modifications to outputted wikicode (of the article tag and the user talk notice)
    • add tests
    • minor refactoring of some unrelated code
  • tag module
    • remove {{Merge}}, {{Merge to}}, and {{Merge from}}, since gnomes are currently manually converting all these to AFDs. will save them some work. folks need to use the new process.
  • a more detailed list of changes can be found in the ticket: xfd: add support for preferred outcome (delete, merge, redirect, draftify) at AFD #2335

Fixes #2335

New dropdown:
2026-04-11_022709

New target page input box, new default reason:
2026-04-13_051136

Warning message when target page doesn't exist (non-fatal error):
image

@NovemLinguae
xfd: add "desired outcome" dropdown
08b3ac1 
Why
- a recent RFC decided to bring the merging process into the AFD process, instead of placing maintenance tags and using talk pages

What
- add dropdown called "Desired outcome:" with options delete, merge, redirect, and draftify
- add |outcome= to tagging wikicode when merge, redirect, or draftify are selected
- refactor tagging wikicode to not use ternaries (more readable)

Note that Twinkle uses {{subst:Afd}} and {{subst:Afdx}}, not {{subst:Article for deletion/dated}} directly. Those two templates will need to be modified with template editor edit requests. That doesn't need to hold up this patch though.

Example wikicode outputted by this patch:

Delete:
- `{{subst:afd|help=off}}\n`
- `{{subst:afdx|18th|help=off}}\n`

Merge:
- `{{subst:afd|help=off|outcome=merging}}\n`
- `{{subst:afdx|18th|help=off|outcome=merging}}\n`

If you want the params in a different order, let me know.

Related #2335
@NovemLinguae
2 code review fixes
8997664
@NovemLinguae
implement code review comment
3b16968
@NovemLinguae
xfd: add more logic to AFD "Draftify" option
d012554 
This is a patch chain, and this patch is number 2. **Earlier patches need to merge first.** The "changed files" tab will include code from earlier patches due to GitHub limitations, until earlier patches are merged and this patch is rebased.

Why
- #2335

What
- add |outcome=draftification to {{Afd notify}} left on user's talk page
- pre-fill some draftify text in the AFD reason textarea. the specific verbiage I chose was `I propose '''draftifying''' because `. Changing away from the draftify outcome in the dropdown blanks the reason textarea.
- refactor
@NovemLinguae
make list more compact, refactor nearby
f81844b
@NovemLinguae
put back. will fix this in a separate patch
baf4aea
@NovemLinguae
xfd: add more logic to AFD "Redirect" option
ae4a9f3 
This is a patch chain, and this patch is number 3. **Earlier patches need to merge first.** Then rebase this one to fix the "files changed" tab.

Why
- #2335

What
- add "Target page" text box for "Redirect" option in dropdown
- add `|target=TargetPage` to {{Afd}} and {{Afdx}}
- add `|target=TargetPage` to {{Afd notify}}
- pre-fill some redirection text in the AFD reason textarea. the specific verbiage I chose was `I propose '''redirecting''' because `.

Example text written to user talk:
- `{{subst:afdx|3rd|help=off|outcome=redirecting|target=PageToRedirectTo}}`
- `{{subst:afd notice|outcome=redirecting|target=PageToRedirectTo|order=  (3rd nomination)|1=NovemTest110}} ~~~~`
@siddharthvp siddharthvp mentioned this pull request Apr 13, 2026
Closed
siddharthvp
siddharthvp reviewed Apr 15, 2026
View reviewed changes
Comment thread src/modules/twinklexfd.js Outdated
Comment thread src/modules/twinklexfd.js Outdated
@NovemLinguae NovemLinguae mentioned this pull request Apr 16, 2026
Closed
@NovemLinguae NovemLinguae changed the title xfd: add more logic to AFD "Redirect" option xfd: add "desired outcome" dropdown, part 1 Apr 16, 2026
@NovemLinguae
NovemLinguae marked this pull request as draft April 17, 2026 00:01
@NovemLinguae NovemLinguae changed the title xfd: add "desired outcome" dropdown, part 1 xfd: add "desired outcome" dropdown Apr 17, 2026
@github-actions github-actions Bot added the tests label Apr 17, 2026
@NovemLinguae NovemLinguae changed the title xfd: add "desired outcome" dropdown xfd: add "desired outcome" dropdown (with delete, merge, redirect, draftify), and remove {{Merge}} tags from tag module Apr 18, 2026
@NovemLinguae NovemLinguae changed the title xfd: add "desired outcome" dropdown (with delete, merge, redirect, draftify), and remove {{Merge}} tags from tag module xfd, tag: add "desired outcome" dropdown (with delete, merge, redirect, draftify), and remove {{Merge}} tags from tag module Apr 18, 2026
@NovemLinguae
NovemLinguae marked this pull request as ready for review April 18, 2026 23:17
@NovemLinguae

NovemLinguae commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

I merged all patches together into this patch. This is ready for final review.

siddharthvp
siddharthvp reviewed Apr 20, 2026
View reviewed changes
Comment thread src/modules/twinkletag.js Outdated
Comment thread src/modules/twinklexfd.js Outdated
Comment thread src/modules/twinklexfd.js Outdated
siddharthvp
siddharthvp reviewed Apr 20, 2026
View reviewed changes
Comment thread tests/twinklexfd.test.js Outdated
Comment thread src/modules/twinklexfd.js Outdated
@NovemLinguae

NovemLinguae commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

I plan to self merge this on Monday unless there's objections. Twinkle is currently placing non-ideal wikicode that needs manual correction by gnomes, and this patch would fix it, reducing their workload.

@NovemLinguae
make test code less verbose
0937bd2 
Co-authored-by: Copilot <copilot@github.com>
@NovemLinguae
NovemLinguae merged commit 34e6b97 into master Apr 27, 2026
5 checks passed
@NovemLinguae
NovemLinguae deleted the afd-merge-3 branch April 27, 2026 11:31
@NovemLinguae

NovemLinguae commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'm not sure why Copilot thinks it's a co-author of this huge patch I spent a lot of time writing. That's pretty annoying. GitHub's marketing department and robots shouldn't be permitted to insert stuff like this without even prompting me.

image

@siddharthvp

siddharthvp commented Apr 28, 2026

Copy link
Copy Markdown
Member

Seems to have come from the last commit which had Co-authored-by: Copilot <copilot@github.com> and was kept while squashing. I always clean up the commit message while squashing instead of keeping the full history of intermediate commits.

@NovemLinguae

NovemLinguae commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

After some digging I figured out it is a recent change to the VS Code GitHub Copilot plugin, and can be disabled in VS Code settings.

@siddharthvp siddharthvp mentioned this pull request Aug 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthvp siddharthvp siddharthvp left review comments

Assignees

No one assigned

Labels

Module: tag Module: xfd tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xfd: add support for preferred outcome (delete, merge, redirect, draftify) at AFD

2 participants

@NovemLinguae @siddharthvp