Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Dec 7, 2025

Fixes https://jira.cfdata.org/browse/DEVX-2371


  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tracked elsewhere
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: autoconfig is not in v3

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2025

🦋 Changeset detected

Latest commit: 8944c77

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 7, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11549

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11549

miniflare

npm i https://pkg.pr.new/miniflare@11549

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11549

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11549

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11549

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11549

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11549

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11549

wrangler

npm i https://pkg.pr.new/wrangler@11549

commit: 8944c77

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2371/autoconfig-vike branch from 31e30e7 to 739bdad Compare December 7, 2025 14:28
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2371/autoconfig-vike branch from b195a2b to 562f687 Compare December 17, 2025 10:10
@claude
Copy link
Contributor

claude bot commented Dec 17, 2025

Claude finished @dario-piotrowicz's task —— View job


Changeset Review

⚠️ Issues found

Both changeset files need improvement:

.changeset/big-crabs-agree.md (create-cloudflare)

  • Missing usage example: The description "Support Vike in --experimental mode" is too brief
  • According to .changeset/README.md, new features should include examples showing users how to use the functionality
  • Should explain what --experimental mode means and provide a command example

.changeset/tiny-tires-write.md (wrangler)

  • Missing usage example: The description "Support Vike in autoconfig" is too brief
  • Should explain what autoconfig does for Vike projects
  • Should include an example of how users will experience this (e.g., what happens when they run wrangler deploy in a Vike project)

What's correct ✅

  • Version types: Both use minor (correct for new features)
  • No major version bump for wrangler
  • No forbidden markdown headers (h1/h2/h3)

Suggested improvements

For big-crabs-agree.md:

---
"create-cloudflare": minor
---

Support Vike in `--experimental` mode

You can now use C3 to scaffold Vike projects with Cloudflare integration:

\`\`\`bash
pnpm create cloudflare --experimental vike my-vike-app
\`\`\`

This creates a Vike project configured for deployment to Cloudflare Pages.

For tiny-tires-write.md:

---
"wrangler": minor
---

Support Vike in autoconfig

Wrangler now automatically detects and configures Vike projects for deployment. When you run `wrangler deploy` in a Vike project, the necessary build commands and compatibility settings are automatically configured without requiring manual wrangler.toml configuration.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2371/autoconfig-vike branch from 562f687 to 95afb34 Compare December 17, 2025 10:42
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review December 17, 2025 10:43
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 17, 2025 10:43
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2371/autoconfig-vike branch 2 times, most recently from cd1f4df to b8f4819 Compare December 17, 2025 11:33
Comment on lines +9 to +12
// Note: the vike create CLI supports a `--cloudflare` argument for creating cloudflare-ready
// projects, that works great but here we don't want to use that because we do want to
// exercise the general autoconfig/`wrangler setup` functionality (which amongst other
// things lets up ensure that we can support the migration of existing vike projects)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to use the flag in C3, and leave the autoconfig stuff for other sites created without it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely, but I think we need to implement a solution that does allow us to run C3 in both case, with and without a template. The template implementation should be the user facing one, while the autoconfig one should be for e2e tests.

Given the experimental state of this in C3 I would progress with just this implementation now and clean things up later.

I've also captured this in: https://jira.cfdata.org/browse/DEVX-2379

what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit icky to add a template just for e2e tests, but if there's no better way then sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I agree 😕

but right now I cannot see a better path forward (that doesn't require a significant restructuring of how we run these tests)

if it helps any we're doing the exact same thing for Next.js 😅: template vs autoconfig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to handle this differently in future? It would be a lot better if we were testing the actual thing we're using in prod.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to handle this differently in future?

Yes, the plan is that, before going GA, we'd switch back to using templates and have the e2e tests run using those.

Ideally we should also have a non user facing (or more precisely... user facing but hidden) way of running C3 that doesn't use templates and we'd run additional e2e tests for those cases as well.

It would be a lot better if we were testing the actual thing we're using in prod.

So we'll be testing both cases, the actual thing that what we use in prod and the non-template variant that is not used in prod but that would help us ensuring that autoconfig keeps working for newer versions of frameworks

Does this sound ok?

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2371/autoconfig-vike branch from b8f4819 to dceedb6 Compare December 17, 2025 17:56
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2371/autoconfig-vike branch from 6facb41 to 1a5aa32 Compare December 18, 2025 12:58
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2371/autoconfig-vike branch from 1a5aa32 to 8944c77 Compare December 18, 2025 13:31
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 18, 2025
@dario-piotrowicz dario-piotrowicz merged commit d059f69 into main Dec 18, 2025
46 of 49 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2371/autoconfig-vike branch December 18, 2025 14:59
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 18, 2025
AmirSa12 pushed a commit to AmirSa12/workers-sdk that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants