Skip to content

Conversation

@jamesopstad
Copy link
Contributor

Use rolldownOptions in plugin config when available.

This improves compatibility with Vite 8 beta and removes warnings related to use of esbuildOptions.


  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: compatibility fix

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

🦋 Changeset detected

Latest commit: 8e077de

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Jan 6, 2026

Claude finished @jamesopstad's task —— View job


Changeset Review

✅ All changesets look good

The changeset properly documents this compatibility improvement with:

  • Correct version type (patch)
  • Clear description of the change and its benefit
  • No formatting issues

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 6, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11807

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11807

miniflare

npm i https://pkg.pr.new/miniflare@11807

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11807

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11807

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11807

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11807

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11807

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11807

wrangler

npm i https://pkg.pr.new/wrangler@11807

commit: 8e077de

@jamesopstad jamesopstad marked this pull request as ready for review January 6, 2026 17:24
@jamesopstad jamesopstad requested a review from a team as a code owner January 6, 2026 17:24
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jan 7, 2026
@jamesopstad jamesopstad merged commit fada563 into main Jan 7, 2026
40 checks passed
@jamesopstad jamesopstad deleted the james/vite-8-config branch January 7, 2026 17:54
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants