[3.7] bpo-35283: Add deprecation warning for Thread.isAlive (GH-11454) #11604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-11454) Add a deprecated warning for the threading.Thread.isAlive() method.. (cherry picked from commit 89669ff) Co-authored-by: Dong-hee Na <[email protected]>
vstinner
reviewed
Jan 18, 2019
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Can you also include the fix https://github.com/python/cpython/pull/11596/files into this PR?
Member
Author
|
No issue yet all |
Member
Author
|
@vstinner Done! |
Member
|
Bye bye isAlive()! I merged your PR @corona10, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pending deprecated warning for the threading.Thread.isAlive() method..
(cherry picked from commit 89669ff)
Co-authored-by: Dong-hee Na [email protected]
https://bugs.python.org/issue35283