Enhance and stabilize API retry handling

[mrrobot47]

This pull request improves the reliability and clarity of the dashboard callback logic in the Site_Backup_Restore.php helper by refining the retry mechanism and enhancing error handling and logging. The changes help ensure that retries are correctly counted and that log messages remain informative, even when responses are missing or errors occur.

Retry logic improvements:

• Changed the retry counting in send_dash_request to use max_attempts (initial attempt plus retries) and start counting from 1 to ensure all intended attempts are made.
• Updated the retry condition to use max_attempts for consistency and accurate logging of attempt numbers.

Error handling and logging enhancements:

• Normalized the response output by introducing response_text, which safely handles cases where no response is received, preventing string concatenation errors in logs.
• Improved error messaging for different failure scenarios: added handling for cURL errors, exhausted retries on 5xx errors, network issues with no HTTP response, and other HTTP error codes, all using the normalized response text.
• Ensured all debug and warning logs use the normalized response text for clarity and consistency.

[Copilot]

Pull request overview

This PR fixes critical bugs in the API retry mechanism for the EasyEngine Dashboard callback functionality. The previous implementation had an off-by-one error that would have caused only 3 total attempts instead of the intended 4 (1 initial + 3 retries), and also had potential issues with string concatenation when cURL returned no response.

Key changes:

• Fixed retry counting to properly execute 4 total attempts (1 initial + 3 retries) by introducing max_attempts and starting the counter at 1
• Added response normalization to prevent concatenation errors when cURL returns false
• Enhanced error handling with specific messages for different failure scenarios including a new edge case for http_code === 0

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.