-
Notifications
You must be signed in to change notification settings - Fork 38
Fix plugin review items #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #111 +/- ##
==========================================
Coverage ? 29.61%
Complexity ? 145
==========================================
Files ? 14
Lines ? 878
Branches ? 0
==========================================
Hits ? 260
Misses ? 618
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| ```php | ||
| add_filter( 'ai_experiment_example-experiment_enabled', '__return_false' ); | ||
| add_filter( 'ai_experiments_experiment_example-experiment_enabled', '__return_false' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:alot: of experiment
|
@dkotter I'm good with these changes, so if you want to share a ZIP from this branch then I can get that over to WPORG while we allow others here to formalize a review (and perhaps iterate on the namespace if desired). |
|
Zip attached here |
justlevine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed the diff from my phone and LGTM, approving since I agree we shouldn't hold things up over naming things.
And tbh it's not even that long (iirc perf is performance-lab)
Above said,
I saw they said no to ai and the guidelines prevent wp, but did they say no to wpai together (no hyphen)? It's short, unambiguous, and follows the plugin naming guidelines.
|
I'll ask about |
TLDR; best to stick with the longer
So I'll leave things as-is with the |
What?
Closes #110
A few minor things were flagged during the plugin review process and this PR fixes those.
Why?
In order to get the plugin on WordPress.org, we need to ensure we pass the plugin review.
How?
AI_EXPERIMENTSandai_experiments(these are pretty lengthy so open to suggestions if we want to shorten this)readme.txtTesting Instructions
Verify all changes look good here and all existing functionality still works