Skip to content

Conversation

@felixarntz
Copy link
Member

@felixarntz felixarntz commented Nov 30, 2025

What?

The Asset_Loader implementation has several problems:

  • The PHP build asset check is wrong, it's currently always failing.
  • RTL language support is missing.
  • The stylesheet file path should be provided to benefit from conditional inlining CSS for performance in WP Core.
  • It's not possible to pass asset data manually, which can lead to unperformant and sometimes inaccurate filemtime calls.

How?

This PR addresses the above issues.

Test using WordPress Playground

The changes in this pull request can be previewed and tested using this WordPress Playground instance:

Click here to test this pull request.

@felixarntz felixarntz requested a review from dkotter November 30, 2025 01:49
@felixarntz felixarntz added the [Type] Bug Something isn't working label Nov 30, 2025
@github-actions
Copy link

github-actions bot commented Nov 30, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: dkotter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz felixarntz requested a review from dkotter December 1, 2025 16:26
@dkotter dkotter merged commit 07f893e into develop Dec 1, 2025
22 of 23 checks passed
@dkotter dkotter deleted the fix/asset-loader-bugs branch December 1, 2025 18:23
@github-project-automation github-project-automation bot moved this from Needs review to Done in WordPress AI Planning & Roadmap Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

4 participants