Skip to content

apply system variables for poetry path #16607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karrtikr merged 6 commits into from
Jul 7, 2021
Merged

apply system variables for poetry path #16607

karrtikr merged 6 commits into from
Jul 7, 2021

Conversation

@tonybaloney
Copy link

@tonybaloney tonybaloney commented Jul 5, 2021

@kimadeline kimadeline requested review from karrtikr and karthiknadig and removed request for kimadeline July 5, 2021 17:16
@kimadeline kimadeline assigned karrtikr and unassigned kimadeline Jul 5, 2021
karrtikr
karrtikr suggested changes Jul 6, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with this solution, it also handles replacing VSCode specific variables, handling relative paths etc. Although I haven't tested this solution out yet, so please let me know if it goes well.

@tonybaloney
Copy link
Author

tonybaloney commented Jul 6, 2021

@karrtikr applied those changes and tested locally, worked nicely.

@karrtikr karrtikr added the skip tests Updates to tests unnecessary label Jul 7, 2021
karrtikr
karrtikr approved these changes Jul 7, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@karrtikr karrtikr merged commit 452d11e into microsoft:main Jul 7, 2021
@tonybaloney tonybaloney deleted the poetry_system_variables branch July 8, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+2 more reviewers

@karrtikr karrtikr karrtikr approved these changes

@paulacamargo25 paulacamargo25 paulacamargo25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karrtikr karrtikr

Labels

skip tests Updates to tests unnecessary

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Poetry environment locator doesn't apply system variables to poetryPath

5 participants

@tonybaloney @karthiknadig @karrtikr @paulacamargo25 @kimadeline