Skip to content

lib: remove Atomics.wake #27033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devsnek merged 1 commit into from
Apr 3, 2019
Merged

lib: remove Atomics.wake #27033

devsnek merged 1 commit into from
Apr 3, 2019
+5 −53

Conversation

@devsnek
Copy link
Member

@devsnek devsnek commented Mar 31, 2019 •
edited
Loading

@nodejs/tsc @nodejs/v8

this has been cooking since 10.x, perhaps we can remove it?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@devsnek devsnek added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 31, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3127

@devsnek devsnek marked this pull request as ready for review March 31, 2019 20:11
@devsnek
Copy link
Member Author

devsnek commented Mar 31, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/22077/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22077/

@devsnek
Copy link
Member Author

devsnek commented Mar 31, 2019

rebuild https://ci.nodejs.org/job/node-test-commit/27355/

@devsnek devsnek added this to the 12.0.0 milestone Mar 31, 2019
@devsnek devsnek added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2019
This was referenced Apr 2, 2019
Closed
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22178/

@devsnek
Copy link
Member Author

devsnek commented Apr 3, 2019

arm rebuild https://ci.nodejs.org/job/node-test-commit-arm-fanned/7766/

@devsnek
lib: remove Atomics.wake
15c0947 
PR-URL: nodejs#27033
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@devsnek devsnek force-pushed the remove-atomics-wake branch from 3da6571 to 15c0947 Compare April 3, 2019 21:56
@devsnek
Copy link
Member Author

devsnek commented Apr 3, 2019

landed in 15c0947

@devsnek devsnek merged commit 15c0947 into nodejs:master Apr 3, 2019
@devsnek devsnek deleted the remove-atomics-wake branch April 3, 2019 21:57
@devsnek devsnek added dont-land-on-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 3, 2019
@devsnek devsnek mentioned this pull request Apr 5, 2019
Merged
BridgeAR
BridgeAR reviewed Apr 9, 2019
View reviewed changes
lib/internal/per_context/setup.js
}

return ReflectApply(AtomicsNotify, this, arguments);
if (global.Atomics) {
Copy link
Member

@BridgeAR BridgeAR Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no safeguard before and AFAIK there's no build where this is not a global. Is this actually needed?

Copy link
Member Author

@devsnek devsnek Apr 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc V8 can disable atomics similarly to how it can disable intl

@BethGriggs BethGriggs mentioned this pull request Apr 11, 2019
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

+1 more reviewer

@apapirovski apapirovski apapirovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@devsnek @nodejs-github-bot @apapirovski @targos @joyeecheung @BridgeAR