Skip to content

build: fix missing fp16 dependency in d8 builds #56266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 17, 2024
Merged

build: fix missing fp16 dependency in d8 builds #56266

nodejs-github-bot merged 1 commit into from
Dec 17, 2024

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 15, 2024

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2024

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 15, 2024
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/64065/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6322/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6322/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6322/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 16, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/64066/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8253290 into nodejs:main Dec 17, 2024
71 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 17, 2024

Landed in 8253290

@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
@ruyadorno ruyadorno mentioned this pull request Dec 20, 2024
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung @nodejs-github-bot @lpinca @targos @richardlau @juanarbol