Add error checks to PyInit_signal()

[tiran]

BPO	24011
Nosy	@vstinner, @tiran, @berkerpeksag, @nanjekyejoannah
PRs	bpo-24011: Use PyModule_AddIntMacro in PyInit__signal() #12765
Files	signalmodule.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-04-22.01:49:13.929>
created_at = <Date 2015-04-19.19:28:15.926>
labels = ['extension-modules', 'type-bug', '3.8']
title = 'Add error checks to PyInit_signal()'
updated_at = <Date 2019-09-06.13:48:35.217>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2019-09-06.13:48:35.217>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-04-22.01:49:13.929>
closer = 'berker.peksag'
components = ['Extension Modules']
creation = <Date 2015-04-19.19:28:15.926>
creator = 'christian.heimes'
dependencies = []
files = ['39127']
hgrepos = []
issue_num = 24011
keywords = ['patch']
message_count = 6.0
messages = ['241551', '323669', '339990', '340627', '340628', '351251']
nosy_count = 4.0
nosy_names = ['vstinner', 'christian.heimes', 'berker.peksag', 'nanjekyejoannah']
pr_nums = ['12765']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24011'
versions = ['Python 3.8']

[tiran]

The init function of the signal module fails to check for errors in a couple of places. The patch replaces PyDict_SetItemString() calls with PyModule_AddIntMacro() and error checks. An exception is unlikely so I'm OK when the patch just lands in 3.4 and 3.5.

CID 1295026 (#41 of 41): Dereference null return value (NULL_RETURNS)
dereference: Dereferencing a pointer that might be null x when calling PyDict_SetItemString

[berkerpeksag]

All of the PyModule_AddIntMacro() changes have already been applied in 6782b14.

The remaining parts are:

-    x = PyLong_FromLong((long)NSIG);
-    if (!x || PyDict_SetItemString(d, "NSIG", x) < 0)
+    if (PyModule_AddIntMacro(m, NSIG))
         goto finally;
-    Py_DECREF(x);

---

-     PyExc_IOError, NULL);
-    if (ItimerError != NULL)
-    PyDict_SetItemString(d, "ItimerError", ItimerError);
+                                     PyExc_IOError, NULL);
+    if (PyModule_AddObject(m, "ItimerError", ItimerError))
+        goto finally;

[nanjekyejoannah]

@berkerpeksag I made the requested changes on the PR. PTAL.

[berkerpeksag]

New changeset 9541bd3 by Berker Peksag (Joannah Nanjekye) in branch 'master':
bpo-24011: Use PyModule_Add{Object,IntMacro} in PyInit__signal() (GH-12765)
9541bd3

[berkerpeksag]

Thank you, Joannah. There's no need to backport PR 12765 to maintenance branches, so I'm closing this issue as 'fixed'.

[vstinner]

There is a regression related to reference count: see bpo-38037.