bpo-32720: Fixed the replacement field grammar documentation. #5544
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`arg_name` and `element_index` are defined as `digit` instead of `integer`.
nathankerr96
suggested changes
Feb 5, 2018
Contributor
nathankerr96
left a comment
nathankerr96
left a comment
There was a problem hiding this comment.
I believe these should be "digit+" since we can use one or more digits
Member
Author
|
@nathankerr96 Yes you're right :) Thanks. Updated. |
Contributor
|
Great, thanks for making this change. I got caught up in the process of submitting my first pr and didn't do my due diligence. I should have caught this the first time around. Thanks again! |
serhiy-storchaka
approved these changes
Feb 5, 2018
Contributor
|
Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Member
Author
|
Thanks :) |
|
GH-5546 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 5, 2018
…GH-5544) `arg_name` and `element_index` are defined as `digit`+ instead of `integer`. (cherry picked from commit 7a561af) Co-authored-by: Mariatta <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 5, 2018
…GH-5544) `arg_name` and `element_index` are defined as `digit`+ instead of `integer`. (cherry picked from commit 7a561af) Co-authored-by: Mariatta <[email protected]>
|
GH-5547 is a backport of this pull request to the 3.6 branch. |
Mariatta
added a commit
that referenced
this pull request
Feb 7, 2018
… (GH-5546) `arg_name` and `element_index` are defined as `digit`+ instead of `integer`. (cherry picked from commit 7a561af) Co-authored-by: Mariatta <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Feb 12, 2018
… (GH-5547) `arg_name` and `element_index` are defined as `digit`+ instead of `integer`. (cherry picked from commit 7a561af) Co-authored-by: Mariatta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arg_nameandelement_indexare defined asdigitinstead ofinteger.https://bugs.python.org/issue32720