Skip to content

Support nickname creating user #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 2 commits into from
Apr 26, 2024
Merged

Support nickname creating user #495

swissspidy merged 2 commits into from
Apr 26, 2024

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Apr 23, 2024

Fixes #274

  • Support nickname creating user
  • Add tests for user creation with nickname

@ernilambar ernilambar marked this pull request as ready for review April 23, 2024 10:20
@ernilambar ernilambar requested a review from a team as a code owner April 23, 2024 10:20
@swissspidy swissspidy added command:user-create Related to 'user create' command command:user-update Related to 'user update' command labels Apr 25, 2024
@swissspidy swissspidy added this to the 2.7.0 milestone Apr 25, 2024
@swissspidy
Copy link
Member

swissspidy commented Apr 25, 2024

Mind rebasing?

@ernilambar
Copy link
Member Author

ernilambar commented Apr 25, 2024

I think test will not pass even after rebasing due to #491

@swissspidy
Copy link
Member

swissspidy commented Apr 25, 2024

The WP trunk tests will still fail, but at least the WP latest tests will pass :-)

@ernilambar
Copy link
Member Author

ernilambar commented Apr 25, 2024

Hmm. It seems for Latest also #494 needs to be merged first.

@swissspidy swissspidy merged commit 55f8309 into wp-cli:main Apr 26, 2024
@ernilambar ernilambar deleted the 274-user-nickname branch April 26, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

command:user-create Related to 'user create' command command:user-update Related to 'user update' command

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

wp user create ignores --nickname

2 participants

@ernilambar @swissspidy