Skip to content

Conversation

@UmeshSingla
Copy link
Contributor

@UmeshSingla UmeshSingla commented Jun 13, 2024

@UmeshSingla UmeshSingla requested a review from a team as a code owner June 13, 2024 08:45
@ernilambar
Copy link
Member

Do we have official page with list of all WordPress Locale codes?

https://translate.wordpress.org/
In this page also, it is not clear about Language Code and WordPress Locale code.

@swissspidy
Copy link
Member

Why add an additional example for pt_PT that is exactly the same as the wp language core install ja one? 🤔 I don't see the value in providing an example for every locale.

@ernilambar
Copy link
Member

@swissspidy Context #90 (comment)

@swissspidy
Copy link
Member

OK, thanks I see the context now on the issue.

Instead of adding the same example for multiple locales, it would be better to just explain the expected format, in case that it's unclear.

Do we have official page with list of all WordPress Locale codes?
In this page also, it is not clear about Language Code and WordPress Locale code.

It's the grey text below the name:

Screenshot 2024-06-13 at 10 52 37

@UmeshSingla
Copy link
Contributor Author

UmeshSingla commented Jun 13, 2024

@swissspidy

Instead of adding the same example for multiple locales, it would be better to just explain the expected format, in case that it's unclear.

While on it, should I update the existing example with a different language code, which has language code along with the country code in it?

Planning on modifying the text "Language code to install." to "Language code to install, it is based on the ISO-639 language code (e.g. pt for Portuguese) followed by the ISO-3166 country code (e.g. PT for Portugal or BR for Brazil). So, the Brazilian Portuguese file would be called pt_BR" It's just that it's bit too long, hope that isn't an isue?

I've taken that from wordpress.org

I've updated the PR.

@swissspidy swissspidy merged commit a9b5ae5 into wp-cli:main Jun 21, 2024
@swissspidy swissspidy added this to the 2.0.21 milestone Jun 21, 2024
@swissspidy swissspidy mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants