Evaluate $upgrading numeric value when checking if maintenance mode is active

[selul]

Attempt to fix #19 by checking the upgrading value when seeing if the site is in maintenance mode or not. Re-use the logic that core uses -> https://github.com/WordPress/WordPress/blob/master/wp-includes/load.php#L310-L314

[danielbachhuber]

I'd suggest we proceed forward on this path: #22 (comment)

We'll want to make sure we have a few different scenarios covering each of the potential .maintenance file formats.

[selul]

Hey guys,

Thanks for the feedback; I thought to give it another try by adding the warning when the value is a non-numeric one.

Also, I've changed the regex to account for when space might be missing between the = or before ; and tried to add a few tests to cover this.

[danielbachhuber]

@selul It's looking great! Just a few small things to fix up, and then this should be good to land. You'll want to make sure all of the tests are passing too.

[selul]

Thanks for the feedback @danielbachhuber 🚀 !

I've applied the changes.

[danielbachhuber]

Looks pretty solid! Just two small tweaks remaining on my end. I'd love to get another @wp-cli/committers review, though.

[selul]

Thanks for the feedback, @danielbachhuber! I've made the changes!

[danielbachhuber]

Thanks for your work on this, @selul !