Conversation
ivanlele
marked this pull request as draft
May 21, 2026 15:20
ivanlele
force-pushed
the
cherry/uncap-datacarrier-by-default
branch
2 times, most recently
from
May 22, 2026 12:43
97d48ec to
96c6166
Compare
Member
|
Looks good so far, just needs an update to one of the functional tests (or a new functional test) to check it's working correctly |
a189d63 add release note for datacarriersize default change (Greg Sanders) a141e1b Add more OP_RETURN mempool acceptance functional tests (Peter Todd) 0b4048c datacarrier: deprecate startup arguments for future removal (Greg Sanders) 63091b7 test: remove unnecessary -datacarriersize args from tests (Greg Sanders) 9f36962 policy: uncap datacarrier by default (Greg Sanders) Pull request description: Retains the `-datacarrier*` args, marks them as deprecated, and does not require another startup argument for multiple OP_RETURN outputs. If a user has set `-datacarriersize` the value is "budgeted" across all seen OP_RETURN output scriptPubKeys. In other words the total script bytes stays the same, but can be spread across any number of outputs. This is done to not introduce an additional argument to support multiple outputs. I do not advise people use the option with custom arguments and it is marked as deprecated to not mislead as a promise to offer it forever. The argument itself can be removed in some future release to clean up the code and minimize footguns for users. Tree-SHA512: 3da2f1ef2f50884d4da7e50df2121bf175cb826edaa14ba7c3068a6d5b2a70beb426edc55d50338ee1d9686b9f74fdf9e10d30fb26a023a718dd82fa1e77b038
Reverts commit 0b4048c
ivanlele
force-pushed
the
cherry/uncap-datacarrier-by-default
branch
from
May 22, 2026 14:43
96c6166 to
b521a1b
Compare
Collaborator
Author
Pushed the test for this into one of the functional tests. The only thing left is for CI to pass again because of this change. The previous version had almost passed CI here: I'll will monitor new run, but I think it can already be reviewed |
ivanlele
marked this pull request as ready for review
May 22, 2026 14:50
delta1
reviewed
Jun 1, 2026
delta1
approved these changes
Jun 24, 2026
Merged
delta1
added a commit
that referenced
this pull request
Jul 1, 2026
87a57e7 Update manpages (Pablo Greco) 14659b9 Bump version to 23.3.4-rc1 (Pablo Greco) 3a07baa fix: minor fixes (Byron Hambly) 9453858 Remove cirrus YML file (Tom Trevethan) 411fffb Migrate CI to GHA (Tom Trevethan) 83b0fdf Revert "add 'src/rpc/blockchain.cpp:.*trim' to the KNOWN_VIOLATIONS lint checks" (Pablo Greco) 83059be Revert "fix help man" (Pablo Greco) 3e60144 Revert "fix help man" (Pablo Greco) 9584316 datacarrier: Undeprecate configuration option (Anthony Towns) 27f5a4e Merge bitcoin/bitcoin#32406: policy: uncap datacarrier by default (ivanlele) fecf4f1 fix help man (Ruslan Kasheparov) 7647638 add 'src/rpc/blockchain.cpp:.*trim' to the KNOWN_VIOLATIONS lint checks (Ruslan Kasheparov) 8408b79 fix help man (Ruslan Kasheparov) 60a97d1 Enable ELIP203 by default in liquidv1 (Pablo Greco) 7577eb9 Enable ELIP203 by default in liquidtestnet (Pablo Greco) 72e4e1c use break-system-packages for pip (Tom Trevethan) 6515f58 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan) Pull request description: Updates master to dee90f2, which fixes CI and enables ELIP 203 by default, also reverts some RPC changes that we don't want in a minor version. Also cherry-picks #1552 As usual, bump version and update manpages ACKs for top commit: tomt1664: Tested ACK 87a57e7 delta1: ACK 87a57e7; tested locally Tree-SHA512: 708b636ff33e3930fe74b9a76cbe32aa401675fd24a0d1294dcd441b0d3d706c4e1ae4ba63be3b7a61a0df98d744472c6e2cb4b2f5ba615f97679142e475007d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks:
bitcoin/bitcoin@f3bbc746647d1fd23bf5cfe
bitcoin/bitcoin@451ba9a