Deprecate legacy Adopt distributions in v5 - #1186

brunoborges · 2026-07-31T14:40:04Z

Summary

preserve adopt, adopt-hotspot, and adopt-openj9 runtime support
warn that the legacy distributions will be removed in v6 and recommend temurin or semeru
document the v5 deprecation and regenerate the bundled action

Testing

npm test -- --runInBand
npm run format-check
npm run lint
npm run build

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0cd196f2-1044-4d33-96bb-8e794a00b03c

Copilot

🟢 Ready to approve

The deprecation warning is correctly centralized, behavior is preserved, docs are updated consistently, and targeted tests were added for the new warning behavior.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR formalizes the deprecation of legacy AdoptOpenJDK distribution keywords in setup-java v5 while preserving their runtime behavior, and updates user-facing docs plus the bundled dist output accordingly.

Changes:

Emit a deprecation warning when adopt, adopt-hotspot, or adopt-openj9 is selected, recommending temurin/semeru.
Remove the prior runtime notice from the Adopt installer path so the warning is centralized at distribution selection time.
Update documentation/action metadata to mark Adopt keywords as deprecated and regenerate the bundled dist artifact.

File summaries

File	Description
src/distributions/distribution-factory.ts	Adds centralized deprecation warning for legacy Adopt distribution keywords.
src/distributions/adopt/installer.ts	Removes legacy “moved to Temurin” notice to avoid duplicate/late messaging.
README.md	Marks legacy Adopt keywords as deprecated and updates guidance text.
docs/advanced-usage.md	Updates Adopt section note to reflect v5 deprecation / v6 removal guidance.
dist/setup/index.js	Regenerated bundled action output reflecting source changes.
action.yml	Updates `distribution` input description to mention Adopt deprecation/removal timeline.
tests/distributors/distribution-factory.test.ts	Adds coverage asserting warning + installer preservation for Adopt keywords.

Review details

Files reviewed: 6/7 changed files
Comments generated: 0
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

### Description Replace the deprecated AdoptOpenJDK distribution with Temurin in the Maven verification workflow. Preserve `actions/setup-java@v5`, the Java 8/11/17 selections, and the Spark/Scala matrix. The release workflow is intentionally unchanged and remains with its existing owners. ### Validation - YAML parsing and structural comparison passed: only the Java distribution changes. - `git diff --check` passed. - Maven matrix execution remains to be validated in CI. ### Deprecation References - [setup-java v5.7.0 release announcement](https://github.com/actions/setup-java/releases/tag/v5.7.0): deprecates legacy AdoptOpenJDK distributions. The [upstream migration notice](actions/setup-java#1186) recommends `temurin` for `adopt` before its removal in v6. Signed-off-by: Peixin Li <pxLi@nyu.edu>

### Description Replace the deprecated AdoptOpenJDK distribution with Temurin in the Blossom vulnerability-scan job. Keep `actions/setup-java@v5`, Java 8, and all other workflow settings unchanged. ### Validation - YAML parsing and structural comparison passed: only the Java distribution changes. - `git diff --check` passed. - The self-hosted Blossom job was not run locally. ### Deprecation References - [setup-java v5.7.0 release announcement](https://github.com/actions/setup-java/releases/tag/v5.7.0): deprecates legacy AdoptOpenJDK distributions. The [upstream migration notice](actions/setup-java#1186) recommends `temurin` for `adopt` before its removal in v6. Signed-off-by: Peixin Li <pxLi@nyu.edu>

### Description Resolve GitHub Actions deprecation warnings without changing CI coverage: - Upgrade the withResource report upload from `actions/upload-artifact@v4` to the Node 24-based `v7`, preserving the artifact name, path, and failure-handling settings. - Replace the six deprecated AdoptOpenJDK distribution settings with Temurin while preserving every Java version and build matrix. No workflow triggers, audit rules, product code, or shared actions are changed. This is a CI-only dependency update with no change to Spark execution or performance-sensitive code, so runtime performance testing is not required. Validation: - YAML parsing and structural comparison passed; only the intended dependency settings changed. - `git diff --check` passed. - Verified the selected action runtime is Node 24. Live Maven and Blossom workflow runs remain to be validated in CI. ### Checklists Documentation - [ ] Updated for new or modified user-facing features or behaviors - [x] No user-facing change Testing - [ ] Added or modified tests to cover new code paths - [x] Covered by existing tests (Existing `mvn[compile,RAT,scalastyle,docgen]` and Blossom-CI workflows; execution pending in CI.) - [ ] Not required Performance - [ ] Tests ran and results are added in the PR description - [ ] Issue filed with a link in the PR description - [x] Not required ### Deprecation References - [GitHub Actions Node 20 deprecation announcement](https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/): recommends updating to actions that run on Node 24; Node 20 removal is scheduled for September 23, 2026. - [setup-java v5.7.0 release announcement](https://github.com/actions/setup-java/releases/tag/v5.7.0): deprecates legacy AdoptOpenJDK distributions. The [upstream migration notice](actions/setup-java#1186) recommends `temurin` for `adopt` before its removal in v6. Signed-off-by: Peixin Li <pxLi@nyu.edu>

Deprecate legacy Adopt distributions in v5

5e499bc

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0cd196f2-1044-4d33-96bb-8e794a00b03c

brunoborges requested a review from a team as a code owner July 31, 2026 14:40

brunoborges requested review from Copilot and gdams July 31, 2026 14:51

brunoborges mentioned this pull request Jul 31, 2026

Remove AdoptOpenJDK and Adopt OpenJ9 distributions in v6 #1183

Closed

Copilot started reviewing on behalf of brunoborges July 31, 2026 14:52 View session

Copilot AI approved these changes Jul 31, 2026

View reviewed changes

brunoborges merged commit b6effb0 into releases/v5 Jul 31, 2026
407 checks passed

brunoborges deleted the brunoborges-deprecate-adopt-v5 branch July 31, 2026 19:34

devin-ai-integration Bot mentioned this pull request Aug 7, 2026

chore(deps): bump actions/setup-java from 5.4.0 to 5.7.0 livekit/client-sdk-react-native#447

Closed

tri-star mentioned this pull request Aug 24, 2026

ci(deps): bump actions/setup-java from 4.9.1 to 5.7.0 tri-star/sanposcape#60

Closed

Navigation Menu

Deprecate legacy Adopt distributions in v5 - #1186