Public resource URLs shouldn't refer to base API URL

[barjin]

Running the following code on Platform:

from apify_client import ApifyClientAsync
import os

async def main() -> None:
    apify_client = ApifyClientAsync(os.environ['APIFY_TOKEN'], api_url=os.environ['APIFY_API_BASE_URL'])

    kvs = apify_client.key_value_store(os.environ['APIFY_DEFAULT_KEY_VALUE_STORE_ID'])
    print(await kvs.create_keys_public_url())

Leads to this:

---

Platform sets the APIFY_API_BASE_URL to an internal address to simplify communication between the Actors and Apify Platform internals. This shouldn't be used when constructing the public resource URLs (in methods like KVS.create_keys_public_url and similar).

Parity for apify/apify-client-js#744

[B4nan]

@Pijukatel please take a look at this with priority, should be a simple fix just like in the JS version

[Pijukatel]

Hi, I do not think there is a problem in the Python tooling. I believe that what is in the code snippet of the issue description is behaving as expected and is not the actual problem reported in the original issue.

Original issue in Python would be like this:

from apify import Actor

async def main():
    async with Actor:
        default_kvs = await Actor.open_key_value_store()
        public_url = await default_kvs.get_public_url(key="whatever")
        print(public_url)

And this snippet correctly returns public url and not some internal ip address.

[B4nan]

This is about the new method create_keys_public_url added by #453 (and I guess the same applies for the dataset variant).

[barjin]

Good point @Pijukatel, the Python SDK already has the Base API URL / Public URL Base distinction (see e.g. here). This means that this issue is not as pressing as its JS counterpart.

Now that we added the presigned-url-generating methods to JS client, I suppose we should follow up by adding them to the Python client as well (see #497). Those methods (in client) imo still shouldn't base the public resource URLs on the api_url kwarg, though (this issue).

In JS, we'd like to extract the logic from SDK to Client and then only proxy the calls - I suppose we eventually want the same here.

[Pijukatel]

Ok, thanks for explaining the issue to me @barjin . The actual issue manifests in SDK if used like this:
(So it is a little awkward way of getting kvs through Actor's ApifyClient instead of through Actor's own methods)

async def main() -> None:
    async with Actor:
        public_url = await Actor.apify_client.key_value_store(key_value_store_id=os.environ['APIFY_DEFAULT_KEY_VALUE_STORE_ID']).create_keys_public_url()

        print(public_url)