Add precondition to Layout that the align fit in a u32. - #43217
Merged
Merged
Conversation
This precondition takes the form of a behavorial change in `Layout::from_size_align` (so it returns `None` if the `align` is too large) and a new requirement for safe usage of `Layout::from_size_align_unchecked`. Fix rust-lang#30170.
Contributor
Author
|
cc #32838 |
12 tasks
pnkfelix
added
the
S-waiting-on-review
Member
Member
arielb1
added
S-waiting-on-bors
Contributor
|
@bors r=alexcrichton |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit ef8804b has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jul 28, 2017
…xcrichton Add precondition to `Layout` that the `align` fit in a u32. Add precondition to `Layout` that the `align` not exceed 2^31. This precondition takes the form of a behavorial change in `Layout::from_size_align` (so it returns `None` if the input `align` is too large) and a new requirement for safe usage of `Layout::from_size_align_unchecked`. Fix #30170.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add precondition to
Layoutthat thealignnot exceed 2^31.This precondition takes the form of a behavorial change in
Layout::from_size_align(so it returnsNoneif the inputalignis too large) and a new requirement for safe usage ofLayout::from_size_align_unchecked.Fix #30170.